@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix call to undefined method PhrictionDocumentTitleTransaction::renderHandleLink() master

Summary: `PhrictionDocumentTitleTransaction` calls `$this->renderHandleLink()`. `PhabricatorApplicationTransaction` defines that method `public function renderHandleLink($phid)`. PhrictionDocumentTitleTransaction extends PhrictionDocumentVersionTransaction extends PhrictionDocumentTransactionType extends PhabricatorModularTransactionType extends Phobject. No PhabricatorApplicationTransaction in that ancestor tree. Thus this call will fail. Thus replace `renderHandleLink()` with `renderHandle()` which accepts a PHID as its parameter (credits to mainframe98 for finding out). Test Plan: Unclear how to trigger via the UI, so run static code analysis and read/grep the code. Reviewers: O1 Blessed Committers, mainframe98, valerio.bozzolan Reviewed By: O1 Blessed Committers, mainframe98, valerio.bozzolan Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Tags: #phriction Differential Revision: https://we.phorge.it/D25752


+1 -1
1 changed file