From 6b9b0490ddf5a737a4a3a07aa487dae2a23858a9 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Fri, 2 May 2025 19:36:04 +0300 Subject: [PATCH] Fix call to undefined method PhrictionDocumentTitleTransaction::renderHandleLink() Summary: `PhrictionDocumentTitleTransaction` calls `$this->renderHandleLink()`. `PhabricatorApplicationTransaction` defines that method `public function renderHandleLink($phid)`. PhrictionDocumentTitleTransaction extends PhrictionDocumentVersionTransaction extends PhrictionDocumentTransactionType extends PhabricatorModularTransactionType extends Phobject. No PhabricatorApplicationTransaction in that ancestor tree. Thus this call will fail. Thus replace `renderHandleLink()` with `renderHandle()` which accepts a PHID as its parameter (credits to mainframe98 for finding out). Test Plan: Unclear how to trigger via the UI, so run static code analysis and read/grep the code. Reviewers: O1 Blessed Committers, mainframe98, valerio.bozzolan Reviewed By: O1 Blessed Committers, mainframe98, valerio.bozzolan Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Tags: #phriction Differential Revision: https://we.phorge.it/D25752 --- .../phriction/xaction/PhrictionDocumentTitleTransaction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php b/src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php index 134a4540ee..1e01914498 100644 --- a/src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php +++ b/src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php @@ -47,7 +47,7 @@ final class PhrictionDocumentTitleTransaction return pht( '%s stubbed out this document when creating %s.', $this->renderAuthor(), - $this->renderHandleLink( + $this->renderHandle( $this->getMetadataValue('stub:create:phid'))); } else { return pht( -- 2.51.2