Mirrored from GitHub github.com/roostorg/coop

Make Scylla-backed features (item investigation & user strikes) optional (#918) master

* Make Scylla-backed features (item investigation, user strikes) optional * Address review: extract shared flag helper, use @ts-expect-error Resolve CodeRabbit nitpicks on PR #918: - Extract the ITEM_INVESTIGATION_AND_STRIKES_ENABLED parsing into a single exported helper (itemInvestigationAndStrikesEnabled) in noOpScylla.ts; the iocContainer factory and the unit test now share it instead of keeping two copies in sync (DRY). - Keep the helper a pure function of its argument (env is read at the call site) so the default-enabled test is independent of the ambient environment. - Replace the 'as unknown as' cast in NoOpScylla.insert() with a scoped @ts-expect-error and justifying comment, per repo guidelines. Co-Authored-By: Rovo Dev <rovodev@atlassian.com> * Fixed formatting * ci: re-trigger E2E (investigate investigation.spec flake vs regression) * Gate user strike logic behind ITEM_INVESTIGATION_AND_STRIKES_ENABLED flag When the flag is false, applyUserStrikeFromPublishedActions early-returns to avoid running strike threshold checks against always-zero counts from the NoOpScylla, which would cause escalation actions to fire unexpectedly. --------- Co-authored-by: Rovo Dev <rovodev@atlassian.com> Co-authored-by: Juan Mrad <juansmrad@gmail.com>


Author Sunil Yadav Co-author Rovo DevCo-author Juan Mrad Committer GitHub Date Commit e4238cd3 Parent 610bcf08
+217
5 changed files