recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Straighten out replication/cache behavior in "bin/storage dump" master

Summary: Fixes T13336. - Prevent `--no-indexes` from being combined with `--for-replica`, since combining these options can only lead to heartbreak. - In `--for-replica` mode, dump caches too. See discussion in T13336. It is probably "safe" to not dump these today, but fragile and not correct. - Mark the "MarkupCache" table as having "Cache" persistence, not "Data" persistence (no need to back it up, since it can be fully regenerated from other datasources). Test Plan: Ran `bin/storage dump` with various combinations of flags. Maniphest Tasks: T13336 Differential Revision: https://secure.phabricator.com/D20743

Author epriestley Date Commit c6642213 Parent 0943561d
+34 -7
4 changed files