@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator

Fix exception handling in ConpherenceViewController::handleRequest() master

Summary: It is only possible `throw` an `Exception` class. `Aphront400Response` is not an Exception class but a `Phobject`. Thus `return` it, like the `Aphront404Response`s within the same method. Test Plan: Check parent classes; run static code analysis. Hack the code to force that return, and successfully obtain an HTTP 400 status code page. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25780


+2 -2
1 changed file