Something went wrong. Try again.
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Something went wrong. Try again.
Speed up DiffusionBrowseFileController by removing call to array_merge master
Summary: Some profiling using XHProf in the Dark Console showed me that Diffusion was wasting a ton of time on array_merge. This change sped up the loading of a large file in Diffusion from 16.8 seconds to 2.4 seconds. Test Plan: Load files in Diffusion. They all look good. Also, use a PHP shell to try to manually verify that I still kinda remember some PHP and, yes, this is functionally equivalent to what was there before. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9032
Author Jacob Hurwitz Committer epriestley Date (May 10, 2014, 1:06 AM UTC) Commit 9d0d1ac4 9d0d1ac42f8a49c4e561d19e5c4111a9a7f8780b Parent e96c363e e96c363eefe79ca7f0254a113f44da8e1c2881f3