recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Fix an issue where storage inlines are fed to InlineAdjustmentEngine master

Summary: Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing. Add the conversion step. Test Plan: Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21239

Author epriestley Date Commit 6dc20d1e Parent e7ebd5d9
+2
1 changed file