Something went wrong. Try again.
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Something went wrong. Try again.
Upgrade File content hashing to SHA256 master
Summary: Ref T12464. This defuses any possible SHA1-collision attacks by using SHA256, for which there is no known collision. (SHA256 hashes are larger -- 256 bits -- so expand the storage column to 64 bytes to hold them.) Test Plan: - Uploaded the same file twice, saw the two files generate the same SHA256 content hash and use the same underlying data. - Tried with a fake hash algorihtm ("quackxyz") to make sure the failure mode worked/degraded correctly if we don't have SHA256 for some reason. Got two valid files with two copies of the same data, as expected. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12464 Differential Revision: https://secure.phabricator.com/D17620
Author epriestley Date (Apr 4, 2017, 11:23 PM UTC) Commit 58011a4e 58011a4e8e7f5f168fd7dd1f53a23a3db1001138 Parent 440ef5b7 440ef5b7a7e48e2aa2370daa09ffd72f356fedcb