recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Validate settings before writing them to the user cache master

Summary: Fixes T11960. In D16998 I removed some code which validated settings on read to improve performance, but lost this replacement validation in shuffling the patch stack. This restores similar validation before we write the cache. This has the same effect, it's just faster. Also, bump the cache key to wipe out anything that got bitten (like my account on `secure` rendering dates wrong). Test Plan: - Edited settings, verified the edits held. - Faked invalid settings, saw the check throw exceptions. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11960 Differential Revision: https://secure.phabricator.com/D17008

Author epriestley Date Commit 49509261 Parent e8d9c676
+11 -1
1 changed file