recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Fix an unusual nonterminating task graph node master

Summary: Fixes T12114. There were a couple of bugs here: - We could draw too many joining lines if a node had a parent with multiple descendants. - We could incorrectly ignore columns because of an `unset()`. I //think// this fixes both things without collateral damage. This whole thing is a little hard to understand/debug and has grown beyond its original scope, so I'll probably rewrite it if there are more issues. Test Plan: - Unit tests. - My local repro is clean now: {F2424920} Reviewers: chad Reviewed By: chad Maniphest Tasks: T12114 Differential Revision: https://secure.phabricator.com/D17211

Author epriestley Date Commit 48187cdb Parent a4a94856
+30 -7
2 changed files