recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Conduit: Improve error handling calling flag.edit without objectPHID master

Summary: Avoid an ugly AphrontQueryException. Throw a proper error code instead. ``` EXCEPTION: (AphrontQueryException) #1048: Column 'objectPHID' cannot be null at [<phorge>/src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:396] ``` Closes T16442 Test Plan: Go to http://phorge.localhost/conduit/method/flag.edit/ and press the "Call Method" button Reviewers: O1 Blessed Committers, mainframe98 Reviewed By: O1 Blessed Committers, mainframe98 Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16442 Differential Revision: https://we.phorge.it/D26644

Author Andre Klapper Date Commit 448a342d Parent 950640dd
+9
1 changed file