recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Conduit: Improve error handling calling file.uploadchunk/file.querychunks without PHID master

Summary: Throw a proper error code and error_info, like similar `file.download` and `file.info` already do. Test Plan: * Go to http://phorge.localhost/conduit/method/file.uploadchunk and http://phorge.localhost/conduit/method/file.querychunks , click "Call Method" * Before this patch, get a generic "ERR-CONDUIT-CORE" error code. * After this patch, get a "ERR-BAD-PHID" error code and the error info `No such file exists.` Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D26754

Author Andre Klapper Date Commit 18b9acba Parent 847756d7