recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
Star
Fork 0
Watch

Fix an error when users receive notifications about objects they can no longer see master

Summary: Ref T13623. The change in D21577 could lead to a case where we try to access stories the user can't see. Move the story-loading piece to "willFilterPage()" to make our way thorugh this. Test Plan: - Made FeedStory return nothing to simulate invisible notifications, loaded page. - Before: index access fatal. - After: clean "no notifications". - Loaded notifications normally, saw normal notifications. Maniphest Tasks: T13623 Differential Revision: https://secure.phabricator.com/D21603

Author epriestley Date Commit 0815891e Parent 4cff4dc6
+38 -23
1 changed file