## Summary This PR effectively enables testing for all the Windows related stuff that is coming soon. > [!IMPORTANT] >This PR builds on top of #11782 which fixes the last (as we speak) bug that we have in the Windows pipeline. So it would be great to review that PR first and then work on this one. Then we'll have the real windows testing, basically achieving parity, infrastructurally, with the other platforms. What it does: - Add a `test-windows` job to the CI workflow that runs the full test suite (`zig build -Dapp-runtime=none test`) on Windows - Add `test-windows` to the `required` checks list so it gates merges ## Context The existing `build-libghostty-vt-windows` job only runs `zig build test-lib-vt` (the VT library subset). I realized that in c5092b09d we removed the TODO comment in that job: "Work towards passing the full test suite on Windows." But effectively we weren't running tests in CI yet! The full test suite now passes on Windows (51/51 steps, 2654 tests, 23 skipped). This job mirrors what the other platforms do — Linux runs `zig build -Dapp-runtime=none test` via Nix, macOS runs `zig build test` via Nix. Windows runs the same command directly via `setup-zig` since there's no Nix on Windows. ## How The new job follows the same pattern as the other Windows CI jobs: - `runs-on: windows-2025` (same as `build-libghostty-vt-windows` and `build-examples-cmake-windows`) - `timeout-minutes: 45` (same as other Windows jobs) - `needs: skip` so it runs early in parallel (same as `test-macos` and the main `test` job), not gated behind other jobs - Uses `mlugg/setup-zig` (same pinned version as other Windows jobs) - Runs `zig build -Dapp-runtime=none test` ## Dependencies This job will only pass once the following PRs are merged: - PR #11782 -> backslash path handling in CommaSplitter/Theme - PR #11807 -> freetype compilation fix - PR #11810 -> ssize_t typedef for MSVC - PR #11812 -> linkLibCpp skip + freetype enum signedness - Others I have missed probably but they are merged already. ## Test plan - The workflow YAML is valid (standard GitHub Actions syntax, matches existing job patterns) - I will be ready to issue fix PRs if any issue related to this arises. I cannot reliably test GH actions locally unfortunately. - Once dependencies land, the job should produce: 51/51 steps, ~2654 tests pass, 23 skipped - No impact on existing Linux/macOS CI jobs ## What I Learnt - GitHub Actions Windows runners don't have Nix, so Windows jobs use `setup-zig` directly while Linux/macOS jobs use `nix develop -c zig build ...`. The Nix wrapper ensures the exact same environment as the flake, but on Windows we get that consistency from the `setup-zig` action which reads the version from `build.zig.zon`. - The `needs: skip` pattern allows a job to run in parallel with the main test job rather than waiting for it. The main `test` job is the gatekeeper for most build jobs (`needs: test`), but platform-specific test jobs like `test-macos` run in parallel since they're independent. - The `required` job aggregates all needed jobs and uses a grep-based check to determine overall pass/fail, so adding a new job there means it becomes a merge blocker.