From 3b090101a6a1749dd17be36a3a9389f8a526d46b Mon Sep 17 00:00:00 2001 From: eti Date: Tue, 5 May 2026 13:08:33 +0200 Subject: [PATCH] appview: the great uppercasing Passed down by generations of tormented minimalist developers, the great uppercasing is here. Bow down to the great cavaliers of doom so that they can bestow their changes upon you. With this pull request, we are finally free from our wicked casing system. Let it be written. Let it be done. From this day forward, we speak in sentence case. &+ appview/logo: keep logotype & alpha tag lowercase Signed-off-by: eti --- appview/issues/issues.go | 4 +- appview/pages/funcmap.go | 24 ++++---- appview/pages/pages.go | 10 ++-- appview/pages/repoinfo/repoinfo.go | 10 ++-- appview/pages/templates/errors/404.html | 2 +- appview/pages/templates/errors/500.html | 4 +- appview/pages/templates/errors/503.html | 4 +- appview/pages/templates/errors/knot404.html | 2 +- .../pages/templates/fragments/pagination.html | 4 +- .../templates/goodfirstissues/index.html | 4 +- appview/pages/templates/knots/dashboard.html | 8 +-- .../knots/fragments/addMemberModal.html | 8 +-- .../knots/fragments/knotListing.html | 10 ++-- appview/pages/templates/knots/index.html | 10 ++-- .../templates/layouts/fragments/footer.html | 56 +++++++++---------- .../layouts/fragments/footerMinimal.html | 18 +++--- .../templates/layouts/fragments/topbar.html | 24 ++++---- .../pages/templates/layouts/profilebase.html | 4 +- appview/pages/templates/layouts/repobase.html | 19 ++++--- appview/pages/templates/legal/privacy.html | 2 +- appview/pages/templates/legal/terms.html | 2 +- .../notifications/fragments/item.html | 20 +++---- .../pages/templates/notifications/list.html | 6 +- appview/pages/templates/repo/blob.html | 8 +-- appview/pages/templates/repo/branches.html | 2 +- appview/pages/templates/repo/commit.html | 11 ++-- .../pages/templates/repo/compare/compare.html | 2 +- appview/pages/templates/repo/compare/new.html | 2 +- appview/pages/templates/repo/fork.html | 2 +- .../repo/fragments/artifactList.html | 4 +- .../templates/repo/fragments/backlinks.html | 2 +- .../repo/fragments/cloneDropdown.html | 3 +- .../repo/fragments/compareAllowPull.html | 2 +- .../templates/repo/fragments/compareForm.html | 8 +-- .../pages/templates/repo/fragments/diff.html | 10 ++-- .../templates/repo/fragments/diffOpts.html | 4 +- .../repo/fragments/editLabelPanel.html | 10 ++-- .../repo/fragments/externalLinkPanel.html | 1 - .../repo/fragments/feedDropdown.html | 6 +- .../templates/repo/fragments/singleTag.html | 2 +- appview/pages/templates/repo/index.html | 10 ++-- .../issues/fragments/editIssueComment.html | 4 +- .../issues/fragments/issueCommentHeader.html | 2 +- .../repo/issues/fragments/newComment.html | 10 ++-- .../repo/issues/fragments/putIssue.html | 6 +- .../repo/issues/fragments/replyComment.html | 4 +- .../pages/templates/repo/issues/issue.html | 4 +- .../pages/templates/repo/issues/issues.html | 4 +- appview/pages/templates/repo/log.html | 4 +- appview/pages/templates/repo/new.html | 6 +- .../templates/repo/pipelines/pipelines.html | 10 ++-- .../repo/pulls/fragments/pullActions.html | 12 ++-- .../repo/pulls/fragments/pullComposeHost.html | 6 +- .../repo/pulls/fragments/pullHeader.html | 6 +- .../repo/pulls/fragments/pullNewComment.html | 5 +- .../repo/pulls/fragments/pullResubmit.html | 6 +- .../repo/pulls/fragments/pullStack.html | 2 +- .../repo/pulls/fragments/pullStepDetails.html | 2 +- .../repo/pulls/fragments/pullStepReview.html | 8 +-- .../pulls/fragments/summarizedPullHeader.html | 4 +- .../pages/templates/repo/pulls/interdiff.html | 2 +- appview/pages/templates/repo/pulls/patch.html | 4 +- appview/pages/templates/repo/pulls/pull.html | 34 +++++------ appview/pages/templates/repo/pulls/pulls.html | 6 +- .../pages/templates/repo/settings/access.html | 6 +- .../settings/fragments/addLabelDefModal.html | 16 +++--- .../repo/settings/fragments/labelListing.html | 2 +- .../settings/fragments/secretListing.html | 4 +- .../repo/settings/fragments/sidebar.html | 2 +- .../settings/fragments/webhookDeliveries.html | 8 +-- .../templates/repo/settings/general.html | 20 +++---- .../pages/templates/repo/settings/hooks.html | 28 +++++----- .../templates/repo/settings/pipelines.html | 20 +++---- .../pages/templates/repo/settings/sites.html | 34 +++++------ appview/pages/templates/repo/stars.html | 2 +- appview/pages/templates/repo/tag.html | 2 +- appview/pages/templates/repo/tags.html | 6 +- appview/pages/templates/repo/tree.html | 2 +- appview/pages/templates/search/search.html | 2 +- .../pages/templates/spindles/dashboard.html | 6 +- .../spindles/fragments/addMemberModal.html | 8 +-- .../spindles/fragments/spindleListing.html | 4 +- appview/pages/templates/spindles/index.html | 10 ++-- .../pages/templates/strings/dashboard.html | 4 +- .../templates/strings/fragments/form.html | 4 +- appview/pages/templates/strings/string.html | 12 ++-- appview/pages/templates/strings/timeline.html | 2 +- .../templates/timeline/fragments/hero.html | 4 +- .../timeline/fragments/newsletterForm.html | 4 +- .../templates/timeline/fragments/preview.html | 14 ++--- .../timeline/fragments/vouchSuggestions.html | 2 +- appview/pages/templates/timeline/home.html | 12 ++-- .../pages/templates/user/completeSignup.html | 10 ++-- appview/pages/templates/user/followers.html | 2 +- appview/pages/templates/user/following.html | 2 +- .../templates/user/fragments/editAvatar.html | 8 +-- .../templates/user/fragments/editBio.html | 22 ++++---- .../templates/user/fragments/editPins.html | 6 +- .../templates/user/fragments/follow.html | 4 +- .../user/fragments/networkVouches.html | 4 +- .../templates/user/fragments/profileCard.html | 4 +- .../templates/user/fragments/vouchButton.html | 6 +- .../user/fragments/vouchPopover.html | 4 +- appview/pages/templates/user/login.html | 6 +- appview/pages/templates/user/overview.html | 20 +++---- appview/pages/templates/user/repos.html | 2 +- .../pages/templates/user/settings/emails.html | 12 ++-- .../settings/fragments/dangerDeleteToken.html | 12 ++-- .../fragments/dangerPasswordToken.html | 10 ++-- .../user/settings/fragments/emailListing.html | 14 ++--- .../user/settings/fragments/keyListing.html | 4 +- .../user/settings/fragments/sidebar.html | 2 +- .../pages/templates/user/settings/keys.html | 14 ++--- .../user/settings/notifications.html | 4 +- .../templates/user/settings/profile.html | 52 ++++++++--------- .../pages/templates/user/settings/sites.html | 18 +++--- appview/pages/templates/user/signup.html | 4 +- appview/pages/templates/user/strings.html | 2 +- appview/pages/templates/user/vouches.html | 2 +- appview/pulls/comment.go | 2 +- appview/pulls/compose.go | 2 +- appview/pulls/resubmit.go | 2 +- appview/repo/artifact.go | 10 ++-- appview/repo/webhooks.go | 34 +++++------ appview/settings/settings.go | 2 +- appview/state/profile.go | 22 ++++---- blog/templates/fragments/footer.html | 12 ++-- blog/templates/fragments/topbar.html | 4 +- blog/templates/index.html | 4 +- blog/templates/text.html | 6 +- 130 files changed, 541 insertions(+), 544 deletions(-) diff --git a/appview/issues/issues.go b/appview/issues/issues.go index a96a0185..9fb9e861 100644 --- a/appview/issues/issues.go +++ b/appview/issues/issues.go @@ -419,7 +419,7 @@ func (rp *Issues) NewIssueComment(w http.ResponseWriter, r *http.Request) { body := r.FormValue("body") if body == "" { - rp.pages.Notice(w, "issue", "Body is required") + rp.pages.Notice(w, "issue", "Body is required.") return } @@ -1083,7 +1083,7 @@ func (rp *Issues) NewIssue(w http.ResponseWriter, r *http.Request) { tx, err := rp.db.BeginTx(r.Context(), nil) if err != nil { - rp.pages.Notice(w, "issues", "Failed to create issue, try again later") + rp.pages.Notice(w, "issues", "Failed to create issue, try again later.") return } rollback := func() { diff --git a/appview/pages/funcmap.go b/appview/pages/funcmap.go index 5340ca5a..c3b2471b 100644 --- a/appview/pages/funcmap.go +++ b/appview/pages/funcmap.go @@ -487,20 +487,20 @@ func (p *Pages) funcMap() template.FuncMap { "OrderedReactionKinds": models.OrderedReactionKinds, // would be great to have ordered maps right about now "UserSettingsTabs": []tab{ - {"Name": "profile", "Icon": "user"}, - {"Name": "keys", "Icon": "key"}, - {"Name": "emails", "Icon": "mail"}, - {"Name": "notifications", "Icon": "bell"}, - {"Name": "knots", "Icon": "volleyball"}, - {"Name": "spindles", "Icon": "spool"}, - {"Name": "sites", "Icon": "globe"}, + {"Name": "profile", "Label": "Profile", "Icon": "user"}, + {"Name": "keys", "Label": "Keys", "Icon": "key"}, + {"Name": "emails", "Label": "Emails", "Icon": "mail"}, + {"Name": "notifications", "Label": "Notifications", "Icon": "bell"}, + {"Name": "knots", "Label": "Knots", "Icon": "volleyball"}, + {"Name": "spindles", "Label": "Spindles", "Icon": "spool"}, + {"Name": "sites", "Label": "Sites", "Icon": "globe"}, }, "RepoSettingsTabs": []tab{ - {"Name": "general", "Icon": "sliders-horizontal"}, - {"Name": "access", "Icon": "users"}, - {"Name": "pipelines", "Icon": "layers-2"}, - {"Name": "hooks", "Icon": "webhook"}, - {"Name": "sites", "Icon": "globe"}, + {"Name": "general", "Label": "General", "Icon": "sliders-horizontal"}, + {"Name": "access", "Label": "Access", "Icon": "users"}, + {"Name": "pipelines", "Label": "Pipelines", "Icon": "layers-2"}, + {"Name": "hooks", "Label": "Hooks", "Icon": "webhook"}, + {"Name": "sites", "Label": "Sites", "Icon": "globe"}, }, "PdsUserDomain": p.pdsCfg.UserDomain, } diff --git a/appview/pages/pages.go b/appview/pages/pages.go index 22500649..9c7f1515 100644 --- a/appview/pages/pages.go +++ b/appview/pages/pages.go @@ -645,11 +645,11 @@ type ProfileStats struct { func (p *ProfileCard) GetTabs() [][]any { tabs := [][]any{ - {"overview", "overview", "square-chart-gantt", nil}, - {"repos", "repos", "book-marked", p.Stats.RepoCount}, - {"starred", "starred", "star", p.Stats.StarredCount}, - {"strings", "strings", "line-squiggle", p.Stats.StringCount}, - {"vouches", "vouches", "shield", nil}, + {"Overview", "overview", "square-chart-gantt", nil}, + {"Repos", "repos", "book-marked", p.Stats.RepoCount}, + {"Starred", "starred", "star", p.Stats.StarredCount}, + {"Strings", "strings", "line-squiggle", p.Stats.StringCount}, + {"Vouches", "vouches", "shield", nil}, } return tabs diff --git a/appview/pages/repoinfo/repoinfo.go b/appview/pages/repoinfo/repoinfo.go index 61835efd..036d295a 100644 --- a/appview/pages/repoinfo/repoinfo.go +++ b/appview/pages/repoinfo/repoinfo.go @@ -44,14 +44,14 @@ func (r RepoInfo) FullNameWithoutAt() string { func (r RepoInfo) GetTabs() [][]string { tabs := [][]string{ - {"overview", "/", "square-chart-gantt"}, - {"issues", "/issues", "circle-dot"}, - {"pulls", "/pulls", "git-pull-request"}, - {"pipelines", "/pipelines", "layers-2"}, + {"overview", "/", "square-chart-gantt", "Overview"}, + {"issues", "/issues", "circle-dot", "Issues"}, + {"pulls", "/pulls", "git-pull-request", "Pulls"}, + {"pipelines", "/pipelines", "layers-2", "Pipelines"}, } if r.Roles.SettingsAllowed() { - tabs = append(tabs, []string{"settings", "/settings", "cog"}) + tabs = append(tabs, []string{"settings", "/settings", "cog", "Settings"}) } return tabs diff --git a/appview/pages/templates/errors/404.html b/appview/pages/templates/errors/404.html index a034f527..4f195ff2 100644 --- a/appview/pages/templates/errors/404.html +++ b/appview/pages/templates/errors/404.html @@ -19,7 +19,7 @@ diff --git a/appview/pages/templates/errors/500.html b/appview/pages/templates/errors/500.html index 529e2d59..bb77257a 100644 --- a/appview/pages/templates/errors/500.html +++ b/appview/pages/templates/errors/500.html @@ -19,11 +19,11 @@
{{ i "arrow-left" "w-4 h-4" }} - back to home + Back to home
diff --git a/appview/pages/templates/errors/503.html b/appview/pages/templates/errors/503.html index 72575817..f854c2dd 100644 --- a/appview/pages/templates/errors/503.html +++ b/appview/pages/templates/errors/503.html @@ -19,11 +19,11 @@
{{ i "arrow-left" "w-4 h-4" }} - back to timeline + Back to timeline
diff --git a/appview/pages/templates/errors/knot404.html b/appview/pages/templates/errors/knot404.html index c2a4037f..698a5b4d 100644 --- a/appview/pages/templates/errors/knot404.html +++ b/appview/pages/templates/errors/knot404.html @@ -19,7 +19,7 @@ diff --git a/appview/pages/templates/fragments/pagination.html b/appview/pages/templates/fragments/pagination.html index c2e5dcbc..65ed2365 100644 --- a/appview/pages/templates/fragments/pagination.html +++ b/appview/pages/templates/fragments/pagination.html @@ -23,7 +23,7 @@ {{ end }} > {{ i "chevron-left" "w-4 h-4" }} - prev + Prev {{ if gt $page.Offset 0 }} @@ -74,7 +74,7 @@ href="{{ $basePath }}?{{ $queryParams }}&offset={{ $next }}&limit={{ $page.Limit }}" {{ end }} > - next + Next {{ i "chevron-right" "w-4 h-4" }} diff --git a/appview/pages/templates/goodfirstissues/index.html b/appview/pages/templates/goodfirstissues/index.html index b4fa8dd1..f93d28e8 100644 --- a/appview/pages/templates/goodfirstissues/index.html +++ b/appview/pages/templates/goodfirstissues/index.html @@ -141,7 +141,7 @@ href="/goodfirstissues?offset={{ $prev.Offset }}&limit={{ $prev.Limit }}" > {{ i "chevron-left" "w-4 h-4" }} - previous + Previous {{ else }}
@@ -154,7 +154,7 @@ hx-boost="true" href="/goodfirstissues?offset={{ $next.Offset }}&limit={{ $next.Limit }}" > - next + Next {{ i "chevron-right" "w-4 h-4" }} {{ end }} diff --git a/appview/pages/templates/knots/dashboard.html b/appview/pages/templates/knots/dashboard.html index 1f58655a..f3010b0c 100644 --- a/appview/pages/templates/knots/dashboard.html +++ b/appview/pages/templates/knots/dashboard.html @@ -30,7 +30,7 @@ {{ end }} {{ else if .Registration.IsReadOnly }} - {{ i "shield-alert" "w-4 h-4" }} read-only + {{ i "shield-alert" "w-4 h-4" }} Read-only {{ if $isOwner }} {{ block "retryButton" .Registration }} {{ end }} @@ -101,7 +101,7 @@ hx-headers='{"shouldRedirect": "true"}' > {{ i "trash-2" "w-5 h-5" }} - + {{ i "loader-circle" "w-4 h-4 animate-spin hidden group-[.htmx-request]:inline" }} {{ end }} @@ -116,7 +116,7 @@ hx-headers='{"shouldRefresh": "true"}' > {{ i "rotate-ccw" "w-5 h-5" }} - + {{ i "loader-circle" "w-4 h-4 animate-spin hidden group-[.htmx-request]:inline" }} {{ end }} @@ -135,7 +135,7 @@ hx-confirm="Are you sure you want to remove {{ $memberHandle }} from this knot?" > {{ i "user-minus" "w-4 h-4" }} - remove + Remove {{ i "loader-circle" "w-4 h-4 animate-spin hidden group-[.htmx-request]:inline" }} {{ end }} diff --git a/appview/pages/templates/knots/fragments/addMemberModal.html b/appview/pages/templates/knots/fragments/addMemberModal.html index f41f97bb..a029df48 100644 --- a/appview/pages/templates/knots/fragments/addMemberModal.html +++ b/appview/pages/templates/knots/fragments/addMemberModal.html @@ -6,7 +6,7 @@ popovertargetaction="toggle" > {{ i "user-plus" "w-5 h-5" }} - + {{ i "loader-circle" "w-4 h-4 animate-spin hidden group-[.htmx-request]:inline" }} @@ -28,7 +28,7 @@ class="flex flex-col gap-2" >

Members can create repositories and run workflows on this knot.

@@ -51,10 +51,10 @@ popovertargetaction="hide" class="btn w-1/2 flex items-center gap-2 text-red-500 hover:text-red-700 dark:text-red-400 dark:hover:text-red-300" > - {{ i "x" "size-4" }} cancel + {{ i "x" "size-4" }} Cancel {{ end }} @@ -77,7 +77,7 @@ hx-target="#knot-{{.Id}}" > {{ i "rotate-ccw" "w-5 h-5" }} - + {{ i "loader-circle" "w-4 h-4 animate-spin hidden group-[.htmx-request]:inline" }} {{ end }} diff --git a/appview/pages/templates/knots/index.html b/appview/pages/templates/knots/index.html index 638f4d6b..ae8e7969 100644 --- a/appview/pages/templates/knots/index.html +++ b/appview/pages/templates/knots/index.html @@ -48,13 +48,13 @@ {{ define "list" }}
-

your knots

+

Your knots

{{ range $registration := .Registrations }} {{ template "knots/fragments/knotListing" . }} {{ else }}
- no knots registered yet + No knots registered yet
{{ end }}
@@ -64,7 +64,7 @@ {{ define "register" }}
-

register a knot

+

Register a knot

Enter the hostname of your knot to get started.

{{ i "plus" "w-4 h-4" }} - register + Register