From bbba92c80eb57e0e466ad71a75a19189828b8d61 Mon Sep 17 00:00:00 2001 From: zzstoatzz Date: Wed, 8 Apr 2026 23:40:57 -0500 Subject: [PATCH] fix build: drop unused err1 capture in resolveHostAuthority MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 584571a tried to discard the first-attempt error via `_ = err1` to document intent, but zig 0.16 rejects that pattern with "error set is discarded". build failed on the operator's ReleaseFast pipeline and slipped past my local `zig build test` because the test binary is lazy — no test references resolveHostAuthority, so zig never analyzed the function body. `zig build` (the exe) does reach it via frame_worker.processFrame and trips the error immediately. just drop the capture. the comment explaining why only err2 is logged is preserved. --- src/validator.zig | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/validator.zig b/src/validator.zig index 606f266..ab73ef0 100644 --- a/src/validator.zig +++ b/src/validator.zig @@ -578,17 +578,15 @@ pub const Validator = struct { var resolver = &self.host_resolvers[idx]; - // first resolve attempt - var doc = resolver.resolve(parsed) catch |err1| { + // first resolve attempt. the first-attempt error is not captured: + // resolver.resolve upstream collapses everything into + // DidResolutionFailed, so both attempts produce the same error kind + // here and only the second one is worth logging. + var doc = resolver.resolve(parsed) catch { // retry once on network failure - var doc2 = resolver.resolve(parsed) catch |err2| { + var doc2 = resolver.resolve(parsed) catch |err| { _ = self.stats.host_authority_reject_resolve.fetchAdd(1, .monotonic); - // log the second-attempt error kind — first-attempt kind is - // dropped because resolver.resolve already swallows it into - // DidResolutionFailed upstream, so both errors look the same - // here. detail field captures @errorName for upstream triage. - self.sampleLogReject("resolve", did, @errorName(err2), incoming_host_id, 0); - _ = err1; + self.sampleLogReject("resolve", did, @errorName(err), incoming_host_id, 0); return .reject; }; defer doc2.deinit(); -- 2.51.2