From f62223daedcfa97c95958c6a1c913a7884cdb3c3 Mon Sep 17 00:00:00 2001 From: zzstoatzz Date: Mon, 10 Aug 2026 03:02:54 -0500 Subject: [PATCH] retry-config-contract: correct the flakiness note The same idle 32-core box produced 13, 14, 14, 16 and 16 across runs, so the peak is scheduling noise, not the platform difference the previous comment claimed. The tolerance stands; the reasoning behind it was wrong. Co-Authored-By: Claude Opus 5 (1M context) --- tests/retry_config_contract.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/retry_config_contract.py b/tests/retry_config_contract.py index 059c330..5a6b60a 100644 --- a/tests/retry_config_contract.py +++ b/tests/retry_config_contract.py @@ -108,10 +108,11 @@ def run_case(name, mode, count, workers, host_workers, expected_peak, min_peak=N # retry workers share an Io thread pool with the firehose # reconnect and accept loops. A small cap is saturated # regardless, so those cases still assert equality; the - # 16-worker default reproducibly peaks at 13-14 on a 32-core - # Linux box while hitting 16 on macOS. Assert the ceiling holds - # and that the default is still far above the explicit caps -- - # pinning the exact overlap only asserts the scheduler. + # 16-worker default was observed at 13, 14, 14, 16 and 16 across + # runs on one idle 32-core box, so the overlap is scheduling + # noise rather than a property of the host. Assert the ceiling + # holds and that the default stays far above the explicit caps + # -- pinning the exact overlap only asserts the scheduler. assert State.peak <= expected_peak, (name, State.peak, text) assert State.peak >= (expected_peak if min_peak is None else min_peak), ( name, State.peak, text, -- 2.51.2