From a1d92beea4eddfe1a1480ce724ace7aaf9db213b Mon Sep 17 00:00:00 2001 From: Seongmin Lee Date: Tue, 07 Jul 2026 20:52:23 +0000 Subject: [PATCH] appview: don't remove repos on knot deletion Signed-off-by: Seongmin Lee --- appview/ingester.go | 9 +++++---- appview/db/repos.go | 2 ++ appview/knots/knots.go | 13 +++++++------ 3 file(s) changed, 14 insertion(s)(+), 10 deletion(s)(-) diff --git a/appview/ingester.go b/appview/ingester.go --- a/appview/ingester.go +++ b/appview/ingester.go @@ -1211,10 +1211,11 @@ return fmt.Errorf("failed to delete knot: %w", err) } - err = db.RemoveReposByKnot(tx, domain) - if err != nil { - return fmt.Errorf("failed to remove repos by knot: %w", err) - } + l.Error("attempt to delete repos by knot", "knot", domain) + // err = db.RemoveReposByKnot(tx, domain) + // if err != nil { + // return fmt.Errorf("failed to remove repos by knot: %w", err) + // } if registration.Registered != nil { err = i.Enforcer.RemoveKnot(domain) diff --git a/appview/db/repos.go b/appview/db/repos.go --- a/appview/db/repos.go +++ b/appview/db/repos.go @@ -571,11 +571,13 @@ } func RemoveRepo(e Execer, did, rkey string) error { + log.Println("removerepo") _, err := e.Exec(`delete from repos where did = ? and rkey = ?`, did, rkey) return err } func RemoveReposByKnot(e Execer, knot string) error { + log.Println("removereposByKnot") _, err := e.Exec(`delete from repos where knot = ?`, knot) return err } diff --git a/appview/knots/knots.go b/appview/knots/knots.go --- a/appview/knots/knots.go +++ b/appview/knots/knots.go @@ -286,12 +286,13 @@ return } - err = db.RemoveReposByKnot(tx, domain) - if err != nil { - l.Error("failed to delete repos", "err", err) - fail() - return - } + l.Error("attempt to delete repos by knot", "knot", domain) + // err = db.RemoveReposByKnot(tx, domain) + // if err != nil { + // l.Error("failed to delete repos", "err", err) + // fail() + // return + // } // delete from enforcer if it was registered if registration.Registered != nil { -- tangled.sh