From 194e80f30ce1d437cae77e44528975a79205e2bf Mon Sep 17 00:00:00 2001 From: Lewis Date: Thu, 07 May 2026 15:54:35 +0000 Subject: [PATCH] appview,knotserver: 1.14 deploy prep Lewis: May this revision serve well! --- docs/DOCS.md | 16 ++++++++++++++++ appview/db/db.go | 7 +++++++ knotserver/xrpc/version.go | 18 +++++------------- nix/pkgs/knot-unwrapped.nix | 2 +- appview/pages/templates/repo/needsUpgrade.html | 5 +++++ appview/pages/templates/repo/settings/general.html | 4 ++-- 6 file(s) changed, 36 insertion(s)(+), 16 deletion(s)(-) diff --git a/docs/DOCS.md b/docs/DOCS.md --- a/docs/DOCS.md +++ b/docs/DOCS.md @@ -1500,6 +1500,22 @@ Newer migration guides are listed first, and older guides are further down the page. +## Upgrading to v1.14.0-alpha + +Starting with v1.14.0-alpha, the fully knot uses the repoDID as its +canonical handle for repositories. This unlocks repository +renames from the appview UI and changes the wire format for +the following lexicons (`sh.tangled.repo.pull`, `sh.tangled.repo.collaborator`, +`sh.tangled.repo.issue`, `sh.tangled.git.refUpdate`). + +Knots that have not been upgraded may silently drop new push +events, pull requests, issues, and collaborator invites for +repositories they host until upgraded. So upgrade please!!! + +- Upgrade to the latest tag (v1.14.0 or above) +- Head to the [knot dashboard](https://tangled.org/settings/knots) and + hit the "retry" button to verify your knot + ## Upgrading to v1.13.0-alpha Starting with v1.13.0-alpha, every repository on a knot is diff --git a/appview/db/db.go b/appview/db/db.go --- a/appview/db/db.go +++ b/appview/db/db.go @@ -1949,6 +1949,13 @@ }) conn.ExecContext(ctx, "pragma foreign_keys = on;") + orm.RunMigration(conn, logger, "migrate-knots-to-repo-did-rename", func(tx *sql.Tx) error { + _, err := tx.Exec(` + update registrations set needs_upgrade = 1; + `) + return err + }) + return &DB{ db, logger, diff --git a/knotserver/xrpc/version.go b/knotserver/xrpc/version.go --- a/knotserver/xrpc/version.go +++ b/knotserver/xrpc/version.go @@ -19,17 +19,13 @@ return } - var modVer string - var sha string - var modified bool - - for _, mod := range info.Deps { - if mod.Path == "tangled.org/tangled.org/knotserver/xrpc" { - modVer = mod.Version - break - } + modVer := info.Main.Version + if modVer == "" || modVer == "(devel)" { + modVer = "(devel)" } + var sha string + var modified bool for _, setting := range info.Settings { switch setting.Key { case "vcs.revision": @@ -37,10 +33,6 @@ case "vcs.modified": modified = setting.Value == "true" } - } - - if modVer == "" { - modVer = "unknown" } if sha == "" { diff --git a/nix/pkgs/knot-unwrapped.nix b/nix/pkgs/knot-unwrapped.nix --- a/nix/pkgs/knot-unwrapped.nix +++ b/nix/pkgs/knot-unwrapped.nix @@ -4,7 +4,7 @@ sqlite-lib, src, }: let - version = "1.13.0-alpha"; + version = "1.14.0-alpha"; in buildGoApplication { pname = "knot"; diff --git a/appview/pages/templates/repo/needsUpgrade.html b/appview/pages/templates/repo/needsUpgrade.html --- a/appview/pages/templates/repo/needsUpgrade.html +++ b/appview/pages/templates/repo/needsUpgrade.html @@ -53,6 +53,11 @@
{{ i "triangle-alert" "size-5 inline-flex items-center align-middle" }} The knot hosting this repository needs an upgrade. This repository is currently unavailable. +
diff --git a/appview/pages/templates/repo/settings/general.html b/appview/pages/templates/repo/settings/general.html --- a/appview/pages/templates/repo/settings/general.html +++ b/appview/pages/templates/repo/settings/general.html @@ -217,7 +217,7 @@ {{ define "renameRepo" }} {{ if and .RepoInfo.Roles.IsOwner .RepoInfo.RepoDid }} -
+

Rename Repository

Existing git remotes that use the old name will break. Use the @@ -239,7 +239,7 @@