From 10a680cc103e55e10151a393727f06d7732f8319 Mon Sep 17 00:00:00 2001 From: oppiliappan Date: Sun, 4 Jan 2026 06:49:39 +0000 Subject: [PATCH] appview: explicitly set statuscode in NotFound handlers Signed-off-by: oppiliappan --- appview/middleware/middleware.go | 4 ++++ appview/state/router.go | 2 ++ 2 files changed, 6 insertions(+) diff --git a/appview/middleware/middleware.go b/appview/middleware/middleware.go index 65c252ac..a1e16f3d 100644 --- a/appview/middleware/middleware.go +++ b/appview/middleware/middleware.go @@ -223,6 +223,7 @@ func (mw Middleware) ResolveRepo() middlewareFunc { ) if err != nil { log.Println("failed to resolve repo", "err", err) + w.WriteHeader(http.StatusNotFound) mw.pages.ErrorKnot404(w) return } @@ -240,6 +241,7 @@ func (mw Middleware) ResolvePull() middlewareFunc { f, err := mw.repoResolver.Resolve(r) if err != nil { log.Println("failed to fully resolve repo", err) + w.WriteHeader(http.StatusNotFound) mw.pages.ErrorKnot404(w) return } @@ -288,6 +290,7 @@ func (mw Middleware) ResolveIssue(next http.Handler) http.Handler { f, err := mw.repoResolver.Resolve(r) if err != nil { log.Println("failed to fully resolve repo", err) + w.WriteHeader(http.StatusNotFound) mw.pages.ErrorKnot404(w) return } @@ -324,6 +327,7 @@ func (mw Middleware) GoImport() middlewareFunc { f, err := mw.repoResolver.Resolve(r) if err != nil { log.Println("failed to fully resolve repo", err) + w.WriteHeader(http.StatusNotFound) mw.pages.ErrorKnot404(w) return } diff --git a/appview/state/router.go b/appview/state/router.go index b11f12c2..6b14e647 100644 --- a/appview/state/router.go +++ b/appview/state/router.go @@ -109,6 +109,7 @@ func (s *State) UserRouter(mw *middleware.Middleware) http.Handler { }) r.NotFound(func(w http.ResponseWriter, r *http.Request) { + w.WriteHeader(http.StatusNotFound) s.pages.Error404(w) }) @@ -182,6 +183,7 @@ func (s *State) StandardRouter(mw *middleware.Middleware) http.Handler { r.Get("/brand", s.Brand) r.NotFound(func(w http.ResponseWriter, r *http.Request) { + w.WriteHeader(http.StatusNotFound) s.pages.Error404(w) }) return r -- 2.51.2