From ab8fe876eac70eb0ef1bce07dd1f34d23ae8dff0 Mon Sep 17 00:00:00 2001 From: John Griffin Date: Mon, 15 Apr 2024 10:44:55 -0400 Subject: [PATCH] fix: default `NODE_ENV` to `test` (#346) * Default `NODE_ENV` to `test` When running the extension on a fresh install the `NODE_ENV` by default is coming through as `true`. Set this to `test` by default to match `startVitest`. * Update samples/basic/test/env.test.ts --------- Co-authored-by: Vladimir --- samples/basic/test/env.test.ts | 2 +- src/api.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/basic/test/env.test.ts b/samples/basic/test/env.test.ts index 3cd90f4..07b8880 100644 --- a/samples/basic/test/env.test.ts +++ b/samples/basic/test/env.test.ts @@ -3,7 +3,7 @@ import { test, expect } from "vitest"; test('process.env', () => { expect(process.env.TEST).toBe('true'); expect(process.env.VITEST).toBe('true'); - expect(process.env.NODE_ENV).toBe('true'); + expect(process.env.NODE_ENV).toBe('test'); expect(process.env.VITEST_VSCODE).toBe('true'); expect(process.env.TEST_CUSTOM_ENV).toBe('hello'); }); diff --git a/src/api.ts b/src/api.ts index 0b75dfb..f9f0f07 100644 --- a/src/api.ts +++ b/src/api.ts @@ -254,7 +254,7 @@ function createChildVitestProcess(showWarning: boolean, meta: VitestPackage[]) { // https://github.com/vitest-dev/vitest/blob/5c7e9ca05491aeda225ce4616f06eefcd068c0b4/packages/vitest/src/node/cli/cli-api.ts TEST: 'true', VITEST: 'true', - NODE_ENV: env.NODE_ENV ?? process.env.NODE_ENV ?? 'true', + NODE_ENV: env.NODE_ENV ?? process.env.NODE_ENV ?? 'test', }, stdio: 'overlapped', cwd: pnp ? dirname(pnp) : undefined, -- 2.51.2