From d2254df5cbbf9177a9ed24b7d83d14ef71efde57 Mon Sep 17 00:00:00 2001 From: Steven Vandevelde Date: Sun, 20 Sep 2026 15:16:20 +0200 Subject: [PATCH] fix: winamp theme text color --- src/facets/themes/winamp/browser/element.css | 7 ++++++- src/facets/themes/winamp/track-details/element.js | 5 +++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/facets/themes/winamp/browser/element.css b/src/facets/themes/winamp/browser/element.css index a71cb65c..e471d5fd 100644 --- a/src/facets/themes/winamp/browser/element.css +++ b/src/facets/themes/winamp/browser/element.css @@ -2,6 +2,12 @@ display: flex; flex-direction: column; height: 100%; + + /* Don't inherit the surrounding text colour. This element lives inside the + window's , whose UA stylesheet sets `color: CanvasText`; Firefox on + Windows maps that to the OS window text colour, which is white in dark + mode, leaving the search row and action buttons unreadable on the panel. */ + color: var(--text-color); } /*********************************** @@ -43,7 +49,6 @@ search select { } table { - color: var(--text-color); table-layout: fixed; width: 100%; } diff --git a/src/facets/themes/winamp/track-details/element.js b/src/facets/themes/winamp/track-details/element.js index 2b8ad970..b8e29e41 100644 --- a/src/facets/themes/winamp/track-details/element.js +++ b/src/facets/themes/winamp/track-details/element.js @@ -92,6 +92,11 @@ class TrackDetailsElement extends DiffuseElement { display: block; height: 100%; width: 100%; + + /* Don't inherit the surrounding text colour: inside the window's + Firefox on Windows resolves the UA colour to the (white) + OS window text colour, leaving values unreadable on the panel. */ + color: var(--text-color); } .window-body { -- 2.51.2