From 0ed84cf2802e702ea4c8ba39568317490309350c Mon Sep 17 00:00:00 2001 From: Steven Vandevelde Date: Wed, 29 Apr 2026 23:32:07 +0200 Subject: [PATCH] fix: remove ids from foundation --- src/common/foundation.js | 5 ----- src/facets/themes/blur/facet/index.html | 6 +++--- src/facets/themes/winamp/facet/index.html | 9 +++------ src/facets/themes/winamp/facet/index.inline.js | 2 +- 4 files changed, 7 insertions(+), 15 deletions(-) diff --git a/src/common/foundation.js b/src/common/foundation.js index 09bb7c9c..0a4a7e8a 100644 --- a/src/common/foundation.js +++ b/src/common/foundation.js @@ -212,7 +212,6 @@ async function configuratorArtwork() { const ac = new ArtworkConfigurator(); ac.setAttribute("group", GROUP); - ac.setAttribute("id", "artwork"); return findExistingOrAdd(ac, signals.configurator.artwork); } @@ -224,7 +223,6 @@ async function configuratorMetadata() { const mc = new MetadataConfigurator(); mc.setAttribute("group", GROUP); - mc.setAttribute("id", "metadata"); return findExistingOrAdd(mc, signals.configurator.metadata); } @@ -236,7 +234,6 @@ async function input() { const i = new InputConfigurator(); i.setAttribute("group", GROUP); - i.setAttribute("id", "input"); return findExistingOrAdd(i, signals.configurator.input); } @@ -251,7 +248,6 @@ async function scrobbles() { const sc = new ScrobblesConfigurator(); sc.setAttribute("group", GROUP); - sc.setAttribute("id", "scrobbles"); const existing = document.body.querySelector(sc.selector); @@ -412,7 +408,6 @@ async function output(options) { const o = new OutputOrchestrator(); o.setAttribute("group", GROUP); - o.setAttribute("id", "output"); if (options?.namespace) o.setAttribute("namespace", options.namespace); diff --git a/src/facets/themes/blur/facet/index.html b/src/facets/themes/blur/facet/index.html index dcb0904f..24c3e5a8 100644 --- a/src/facets/themes/blur/facet/index.html +++ b/src/facets/themes/blur/facet/index.html @@ -29,20 +29,20 @@
diff --git a/src/facets/themes/winamp/facet/index.html b/src/facets/themes/winamp/facet/index.html index adde6c43..667982d3 100644 --- a/src/facets/themes/winamp/facet/index.html +++ b/src/facets/themes/winamp/facet/index.html @@ -75,19 +75,16 @@ Browse collection - + diff --git a/src/facets/themes/winamp/facet/index.inline.js b/src/facets/themes/winamp/facet/index.inline.js index 39260be5..ed1e9b80 100644 --- a/src/facets/themes/winamp/facet/index.inline.js +++ b/src/facets/themes/winamp/facet/index.inline.js @@ -30,7 +30,7 @@ const { default: WinampElement } = await import( ); /** @type {OutputElement | null} */ -const output = document.querySelector("#output"); +const output = document.querySelector("do-output"); if (!output) throw new Error("Missing output element"); globalThis.queue = queue; -- 2.51.2