From 6906bde22f714d9f488087653b1c85155ef40944 Mon Sep 17 00:00:00 2001
From: Darin McBride <dmcbride@cpan.org>
Date: Thu, 20 Nov 2014 17:11:18 -0700
Subject: [PATCH] Creating new admins is rare, doesn't need to be so trivial. 
 Reduce chances of an accident this way.

New admins can be created at the shell:

perl -I/data/Lacuna-Server/lib -ML -e \
   '$e=L->empire("New Admin Empire"); $e->is_admin(1); $e->chat_admin(1); $e->update'
---
 lib/Lacuna/Web/Admin.pm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/Lacuna/Web/Admin.pm b/lib/Lacuna/Web/Admin.pm
index f8856aee..36a43576 100644
--- a/lib/Lacuna/Web/Admin.pm
+++ b/lib/Lacuna/Web/Admin.pm
@@ -842,6 +842,10 @@ sub www_toggle_isolationist {
     return $self->www_view_empire($request, $id);
 }
 
+=for probably never
+
+Admins are added/removed so rarely, it shouldn't be done so trivially
+
 sub www_toggle_admin {
     my ($self, $request, $id) = @_;
     $id ||= $request->param('id');
@@ -858,6 +862,8 @@ sub www_toggle_admin {
     return $self->www_view_empire($request, $id);
 }
 
+=cut
+
 sub www_toggle_mission_curator {
     my ($self, $request, $id) = @_;
     $id ||= $request->param('id');
@@ -950,7 +956,7 @@ sub www_view_empire {
     $out .= sprintf('<tr><th>Description</th><td>%s</td><td></td></tr>', $empire->description);
     $out .= sprintf('<tr><th>University Level</th><td>%s</td><td><form method="post" style="display: inline" action="/admin/change/university/level"><input type="hidden" name="id" value="%s"><input name="university_level" style="width: 30px;" value="0"><input type="submit" value="change"></form></td></tr>', $empire->university_level, $empire->id);
     $out .= sprintf('<tr><th>Isolationist</th><td>%s</td><td><a href="/admin/toggle/isolationist?id=%s">Toggle</a></td></tr>', $empire->is_isolationist, $empire->id);
-    $out .= sprintf('<tr><th>Admin</th><td>%s</td><td><a href="/admin/toggle/admin?id=%s">Toggle</a></td></tr>', $empire->is_admin, $empire->id);
+    $out .= sprintf('<tr><th>Admin</th><td>%s</td></tr>', $empire->is_admin);
     $out .= sprintf('<tr><th>Mission Curator</th><td>%s</td><td><a href="/admin/toggle/mission/curator?id=%s">Toggle</a></td></tr>', $empire->is_mission_curator, $empire->id);
     $out .= '</table><ul>';
     $out .= sprintf('<li><a href="/admin/become/empire?empire_id=%s">Become This Empire In-Game</a></li>', $empire->id);
-- 
2.51.2