From cb4257e60603dbfa38293f26eefcbaa4aced5bb9 Mon Sep 17 00:00:00 2001 From: Michael Davis Date: Sun, 25 Jan 2026 13:57:34 -0500 Subject: [PATCH] Resolve recent rustc warnings for MessageActionItem Item impl Recent rust versions emit warnings about the elided lifetime on Row (preferring `Row<'_>`) and want the `Item` impl moved to the same block as their item. --- helix-term/src/application.rs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/helix-term/src/application.rs b/helix-term/src/application.rs index ef1ab01d..e14bc7bb 100644 --- a/helix-term/src/application.rs +++ b/helix-term/src/application.rs @@ -1118,12 +1118,6 @@ impl Application { Ok(serde_json::Value::Null) } Ok(MethodCall::ShowMessageRequest(params)) => { - impl ui::menu::Item for lsp::MessageActionItem { - type Data = (); - fn format(&self, _data: &Self::Data) -> tui::widgets::Row { - self.title.as_str().into() - } - } if let Some(actions) = params.actions.filter(|a| !a.is_empty()) { let id = id.clone(); let select = ui::Select::new( @@ -1346,3 +1340,10 @@ impl Application { errs } } + +impl ui::menu::Item for lsp::MessageActionItem { + type Data = (); + fn format(&self, _data: &Self::Data) -> tui::widgets::Row<'_> { + self.title.as_str().into() + } +} -- 2.51.2