From daa9da57388e11ee29cf57c2e8c73c3c040a86ba Mon Sep 17 00:00:00 2001 From: theMackabu Date: Fri, 8 May 2026 18:20:50 -0700 Subject: [PATCH] emit synchronous connect failures on microtask --- src/modules/net.c | 6 +++--- tests/test_net_create_connection.cjs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/net.c b/src/modules/net.c index 7270e80..f558ed0 100644 --- a/src/modules/net.c +++ b/src/modules/net.c @@ -455,7 +455,7 @@ static void net_socket_detach(net_socket_t *socket) { } static void net_socket_emit_error(net_socket_t *socket, const char *message) { - ant_value_t arg = js_mkerr_typed(socket->js, JS_ERR_TYPE, "%s", message); + ant_value_t arg = js_make_error_silent(socket->js, JS_ERR_TYPE, message); socket->had_error = true; net_emit(socket->js, socket->obj, "error", &arg, 1); } @@ -474,7 +474,7 @@ static ant_value_t net_socket_emit_connect_error(ant_t *js, ant_value_t *args, i socket->connecting = false; socket->had_error = true; net_socket_sync_state(socket); - err = js_mkerr_typed(js, JS_ERR_TYPE, "%s", uv_strerror(status)); + err = js_make_error_silent(js, JS_ERR_TYPE, uv_strerror(status)); net_emit(js, socket->obj, "error", &err, 1); if (socket->conn) ant_conn_close(socket->conn); @@ -640,7 +640,7 @@ static void net_socket_on_error(ant_conn_t *conn, int status, void *user_data) { if (!socket) return; socket->had_error = true; { - ant_value_t err = js_mkerr_typed(socket->js, JS_ERR_TYPE, "%s", uv_strerror(status)); + ant_value_t err = js_make_error_silent(socket->js, JS_ERR_TYPE, uv_strerror(status)); net_emit(socket->js, socket->obj, "error", &err, 1); } } diff --git a/tests/test_net_create_connection.cjs b/tests/test_net_create_connection.cjs index ae64b13..3a819ef 100644 --- a/tests/test_net_create_connection.cjs +++ b/tests/test_net_create_connection.cjs @@ -12,7 +12,7 @@ const timeout = setTimeout(() => { }, 2000); function finishWithInvalidHostCheck() { - const socket = net.connect({ host: 'definitely.invalid.ant.local', port: 80 }); + const socket = net.connect({ host: '256.256.256.256', port: 80 }); socket.on('error', (error) => { invalidHostError = true; assert(error instanceof Error); -- 2.51.2