From 362c2b25dab8eca3c6a079d4992db686b22004c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=ADas=20Insaurralde?= Date: Tue, 7 Apr 2026 20:17:33 -0300 Subject: [PATCH] appview/indexer: propagate SearchInContext error instead of nil, nil MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Search was returning nil,nil on error, silently bypassing every caller's error guard and causing a nil pointer dereference on the result. Return nil,err instead. Signed-off-by: Matías Insaurralde --- appview/indexer/issues/indexer.go | 2 +- appview/indexer/pulls/indexer.go | 2 +- appview/indexer/repos/indexer.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/appview/indexer/issues/indexer.go b/appview/indexer/issues/indexer.go index 0da7d3cf..3df3ef69 100644 --- a/appview/indexer/issues/indexer.go +++ b/appview/indexer/issues/indexer.go @@ -309,7 +309,7 @@ func (ix *Indexer) Search(ctx context.Context, opts models.IssueSearchOptions) ( searchReq := bleve.NewSearchRequestOptions(indexerQuery, opts.Page.Limit, opts.Page.Offset, false) res, err := ix.indexer.SearchInContext(ctx, searchReq) if err != nil { - return nil, nil + return nil, err } ret := &SearchResult{ Total: res.Total, diff --git a/appview/indexer/pulls/indexer.go b/appview/indexer/pulls/indexer.go index beb79e47..59d07b1a 100644 --- a/appview/indexer/pulls/indexer.go +++ b/appview/indexer/pulls/indexer.go @@ -310,7 +310,7 @@ func (ix *Indexer) Search(ctx context.Context, opts models.PullSearchOptions) (* searchReq := bleve.NewSearchRequestOptions(indexerQuery, limit, opts.Page.Offset, false) res, err := ix.indexer.SearchInContext(ctx, searchReq) if err != nil { - return nil, nil + return nil, err } ret := &searchResult{ Total: res.Total, diff --git a/appview/indexer/repos/indexer.go b/appview/indexer/repos/indexer.go index b34fade4..815a0f8d 100644 --- a/appview/indexer/repos/indexer.go +++ b/appview/indexer/repos/indexer.go @@ -495,7 +495,7 @@ func (ix *Indexer) Search(ctx context.Context, opts models.RepoSearchOptions) (* res, err := ix.indexer.SearchInContext(ctx, searchReq) if err != nil { - return nil, nil + return nil, err } ret := &SearchResult{ Total: res.Total, -- 2.51.2