From 1b314963539d1503519fcc92817c2000d2110bee Mon Sep 17 00:00:00 2001 From: oppiliappan Date: Mon, 09 Mar 2026 09:44:31 +0000 Subject: [PATCH] appview/config: remove RateLimitBypass Signed-off-by: oppiliappan --- appview/config/config.go | 1 - appview/oauth/handler.go | 20 ++++++-------------- appview/state/state.go | 2 +- 3 file(s) changed, 7 insertion(s)(+), 16 deletion(s)(-) diff --git a/appview/config/config.go b/appview/config/config.go --- a/appview/config/config.go +++ b/appview/config/config.go @@ -17,7 +17,6 @@ AppviewHost string `env:"APPVIEW_HOST, default=tangled.org"` AppviewName string `env:"APPVIEW_Name, default=Tangled"` Dev bool `env:"DEV, default=false"` DisallowedNicknamesFile string `env:"DISALLOWED_NICKNAMES_FILE"` - RateLimitBypass string `env:"PDS_RATE_LIMIT_BYPASS"` // temporarily, to add users to default knot and spindle AppPassword string `env:"APP_PASSWORD"` diff --git a/appview/oauth/handler.go b/appview/oauth/handler.go --- a/appview/oauth/handler.go +++ b/appview/oauth/handler.go @@ -247,14 +247,13 @@ } // create a AppPasswordSession using apppasswords type AppPasswordSession struct { - AccessJwt string `json:"accessJwt"` - PdsEndpoint string - Did string - RateLimitBypass string - Logger *slog.Logger + AccessJwt string `json:"accessJwt"` + PdsEndpoint string + Did string + Logger *slog.Logger } -func CreateAppPasswordSession(res *idresolver.Resolver, appPassword, did, rateLimitBypass string, logger *slog.Logger) (*AppPasswordSession, error) { +func CreateAppPasswordSession(res *idresolver.Resolver, appPassword, did string, logger *slog.Logger) (*AppPasswordSession, error) { if appPassword == "" { return nil, fmt.Errorf("no app password configured") } @@ -284,9 +283,6 @@ if err != nil { return nil, fmt.Errorf("failed to create session request: %v", err) } sessionReq.Header.Set("Content-Type", "application/json") - if rateLimitBypass != "" { - sessionReq.Header.Set("x-ratelimit-bypass", rateLimitBypass) - } logger.Debug("creating app password session", "url", sessionURL, "headers", sessionReq.Header) @@ -308,7 +304,6 @@ } session.PdsEndpoint = pdsEndpoint session.Did = did - session.RateLimitBypass = rateLimitBypass session.Logger = logger return &session, nil @@ -340,9 +335,6 @@ } req.Header.Set("Content-Type", "application/json") req.Header.Set("Authorization", "Bearer "+s.AccessJwt) - if s.RateLimitBypass != "" { - req.Header.Set("x-ratelimit-bypass", s.RateLimitBypass) - } s.Logger.Debug("putting record", "url", url, "collection", collection, "headers", req.Header) @@ -369,7 +361,7 @@ if o.appPasswordSession != nil { return o.appPasswordSession, nil } - session, err := CreateAppPasswordSession(o.IdResolver, o.Config.Core.AppPassword, consts.TangledDid, o.Config.Core.RateLimitBypass, o.Logger) + session, err := CreateAppPasswordSession(o.IdResolver, o.Config.Core.AppPassword, consts.TangledDid, o.Logger) if err != nil { return nil, err } diff --git a/appview/state/state.go b/appview/state/state.go --- a/appview/state/state.go +++ b/appview/state/state.go @@ -622,7 +622,7 @@ logger.Error("no PDS endpoint found for tangled.sh DID") return } - session, err := oauth.CreateAppPasswordSession(res, config.Core.AppPassword, consts.TangledDid, config.Core.RateLimitBypass, logger) + session, err := oauth.CreateAppPasswordSession(res, config.Core.AppPassword, consts.TangledDid, logger) if err != nil { logger.Error("failed to create appassword session... skipping fetch", "err", err) return -- tangled.sh