From 6c78331db1acf0a2c9824f0c1717950d209a8012 Mon Sep 17 00:00:00 2001 From: Tiago Carvalho Date: Mon, 30 Dec 2024 11:18:29 +0000 Subject: [PATCH] avoid overwriting sigs --- src/sign.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/sign.rs b/src/sign.rs index d1c6175..ba6d074 100644 --- a/src/sign.rs +++ b/src/sign.rs @@ -21,9 +21,10 @@ pub fn command(key_path: PathBuf, rev: String) -> Result<()> { let reference = utils::craft_signature_reference(key_fingerprint, signed_object); repo.reference( &reference, tree_oid, - // references to signatures will never change, so it is - // safe to force overwriting faulty references - true, "", + // references to signatures are non-deterministic, + // so we should fail if we attempt to overwrite a + // signature in our local git repository + false, "", ) .context("Failed to store reference to signature")?; println!("Signed with key:"); -- 2.51.2