From 39c8b0854deb618d00e5fa5d0482e57ae9b56dc4 Mon Sep 17 00:00:00 2001 From: eti Date: Sat, 19 Sep 2026 03:05:31 +0200 Subject: [PATCH] web/ui: rescale primitives onto the spacing scale Signed-off-by: eti --- .../components/repo/pulls/PullCompose.svelte | 5 +- .../lib/components/ui/Avatar.stories.svelte | 4 +- .../lib/components/ui/Button.stories.svelte | 14 ++-- web/src/lib/components/ui/Button.svelte | 42 +++++++++--- .../components/ui/ButtonCard.stories.svelte | 2 +- web/src/lib/components/ui/ButtonCard.svelte | 6 +- .../components/ui/ButtonGroup.stories.svelte | 4 +- web/src/lib/components/ui/ButtonGroup.svelte | 6 +- web/src/lib/components/ui/Card.stories.svelte | 15 ++-- web/src/lib/components/ui/Card.svelte | 15 +--- .../lib/components/ui/Checkbox.stories.svelte | 2 +- web/src/lib/components/ui/Checkbox.svelte | 66 ++++++++++-------- web/src/lib/components/ui/Combobox.svelte | 20 +++--- .../components/ui/CopyButton.stories.svelte | 6 +- web/src/lib/components/ui/CopyButton.svelte | 6 +- .../lib/components/ui/Dropdown.stories.svelte | 4 +- web/src/lib/components/ui/Dropdown.svelte | 4 +- web/src/lib/components/ui/DropdownItem.svelte | 2 +- .../components/ui/EmptyState.stories.svelte | 5 +- web/src/lib/components/ui/EmptyState.svelte | 10 ++- web/src/lib/components/ui/Error.svelte | 24 +++---- .../lib/components/ui/Field.stories.svelte | 2 +- .../components/ui/GraphCell.stories.svelte | 12 ++-- .../components/ui/Hovercard.stories.svelte | 4 +- web/src/lib/components/ui/Hovercard.svelte | 2 +- .../lib/components/ui/Input.stories.svelte | 22 +++--- web/src/lib/components/ui/Input.svelte | 4 +- web/src/lib/components/ui/Link.svelte | 4 +- web/src/lib/components/ui/ListPanel.svelte | 25 +++++++ web/src/lib/components/ui/ListToolbar.svelte | 46 +++++++++++++ web/src/lib/components/ui/Logo.stories.svelte | 6 +- web/src/lib/components/ui/Logo.svelte | 4 +- .../lib/components/ui/MarkdownEditor.svelte | 6 +- web/src/lib/components/ui/Modal.svelte | 12 ++-- .../lib/components/ui/MoreMenu.stories.svelte | 2 +- web/src/lib/components/ui/MoreMenu.svelte | 6 +- web/src/lib/components/ui/Pagination.svelte | 6 +- web/src/lib/components/ui/Radio.svelte | 51 +++++++------- .../ui/RangeSelector.stories.svelte | 10 +-- web/src/lib/components/ui/ResizeHandle.svelte | 2 +- .../lib/components/ui/RoutePagination.svelte | 2 +- .../lib/components/ui/Section.stories.svelte | 14 ++-- web/src/lib/components/ui/Section.svelte | 4 +- .../lib/components/ui/Select.stories.svelte | 2 +- web/src/lib/components/ui/Select.svelte | 6 +- .../components/ui/Separator.stories.svelte | 15 ++-- .../components/ui/ShimmerText.stories.svelte | 2 +- web/src/lib/components/ui/SignupPrompt.svelte | 2 +- .../lib/components/ui/Spinner.stories.svelte | 2 +- web/src/lib/components/ui/SplitButton.svelte | 4 +- .../lib/components/ui/TabPanel.stories.svelte | 59 ---------------- web/src/lib/components/ui/TabPanel.svelte | 35 ---------- web/src/lib/components/ui/Tabs.svelte | 16 ++--- web/src/lib/components/ui/Tag.svelte | 18 ++--- web/src/lib/components/ui/TagInput.svelte | 32 +++++---- .../lib/components/ui/Textarea.stories.svelte | 2 +- web/src/lib/components/ui/Textarea.svelte | 10 +-- .../lib/components/ui/Toggle.stories.svelte | 4 +- web/src/lib/components/ui/Toggle.svelte | 68 +++++++++++-------- .../lib/components/ui/Tooltip.stories.svelte | 16 ++--- web/src/lib/components/ui/Tooltip.svelte | 4 +- web/src/lib/components/ui/User.stories.svelte | 2 +- web/src/lib/components/ui/User.svelte | 4 +- web/src/lib/components/ui/inputField.ts | 7 +- 64 files changed, 418 insertions(+), 400 deletions(-) create mode 100644 web/src/lib/components/ui/ListPanel.svelte create mode 100644 web/src/lib/components/ui/ListToolbar.svelte delete mode 100644 web/src/lib/components/ui/TabPanel.stories.svelte delete mode 100644 web/src/lib/components/ui/TabPanel.svelte diff --git a/web/src/lib/components/repo/pulls/PullCompose.svelte b/web/src/lib/components/repo/pulls/PullCompose.svelte index a023cd515..db2dbad38 100644 --- a/web/src/lib/components/repo/pulls/PullCompose.svelte +++ b/web/src/lib/components/repo/pulls/PullCompose.svelte @@ -49,7 +49,6 @@ import Select from "$lib/components/ui/Select.svelte"; import Spinner from "$lib/components/ui/Spinner.svelte"; import StepMarker from "$lib/components/ui/StepMarker.svelte"; - import TabPanel from "$lib/components/ui/TabPanel.svelte"; import Textarea from "$lib/components/ui/Textarea.svelte"; import DiffView from "$lib/components/repo/DiffView.svelte"; import PullCommitList from "$lib/components/repo/pulls/PullCommitList.svelte"; @@ -351,7 +350,7 @@ {/snippet}
- + {#if view.prefillError}
- + {#if view.showDetails && view.source !== "patch"} diff --git a/web/src/lib/components/ui/Avatar.stories.svelte b/web/src/lib/components/ui/Avatar.stories.svelte index dc3410ae0..30f876b30 100644 --- a/web/src/lib/components/ui/Avatar.stories.svelte +++ b/web/src/lib/components/ui/Avatar.stories.svelte @@ -27,9 +27,9 @@ -
+
{#each scale as size (size)} -
+
{size}
diff --git a/web/src/lib/components/ui/Button.stories.svelte b/web/src/lib/components/ui/Button.stories.svelte index d7dd65734..901f6b221 100644 --- a/web/src/lib/components/ui/Button.stories.svelte +++ b/web/src/lib/components/ui/Button.stories.svelte @@ -187,16 +187,17 @@ -
+
-
+
+ - +
@@ -207,16 +208,17 @@ -
+
+ - +
-
+
diff --git a/web/src/lib/components/ui/Button.svelte b/web/src/lib/components/ui/Button.svelte index 2260561c0..1bbca5335 100644 --- a/web/src/lib/components/ui/Button.svelte +++ b/web/src/lib/components/ui/Button.svelte @@ -52,10 +52,15 @@ ] }, size: { - mini: "min-h-6 gap-1 px-1 py-0.5 typography-paragraph-mini", - small: "min-h-8 gap-1.5 px-2 py-1 typography-paragraph-small", - regular: "min-h-9 gap-2 px-3 py-1 typography-paragraph-regular", - large: "min-h-10 gap-2.5 px-4 py-1 typography-paragraph-large" + mini: "min-h-6 gap-2xs px-2xs py-3xs typography-paragraph-mini", + small: "min-h-7 gap-2xs px-2 py-3xs typography-paragraph-small", + regular: "min-h-8 gap-1.5 px-sm py-3xs typography-paragraph-regular", + large: "min-h-9 gap-xs px-sm py-3xs typography-paragraph-large" + }, + iconSide: { + left: "", + right: "", + none: "" }, insetShadow: { true: "", @@ -63,6 +68,14 @@ } }, compoundVariants: [ + { size: "mini", iconSide: "left", class: "pl-1" }, + { size: "mini", iconSide: "right", class: "pr-1" }, + { size: "small", iconSide: "left", class: "pl-1.75" }, + { size: "small", iconSide: "right", class: "pr-1.75" }, + { size: "regular", iconSide: "left", class: "pl-2.25" }, + { size: "regular", iconSide: "right", class: "pr-2.25" }, + { size: "large", iconSide: "left", class: "pl-2.75" }, + { size: "large", iconSide: "right", class: "pr-2.75" }, { variant: ["default", "danger", "success", "warning"], insetShadow: true, @@ -86,6 +99,7 @@ defaultVariants: { variant: "default", size: "regular", + iconSide: "none", insetShadow: false } }); @@ -94,10 +108,10 @@ base: "shrink-0", variants: { size: { - mini: "size-3.5", - small: "size-4", - regular: "size-4", - large: "size-5" + mini: "size-3", + small: "size-3.5", + regular: "size-3.5", + large: "size-4" } }, defaultVariants: { @@ -139,7 +153,7 @@ type?: "button" | "submit" | "reset"; disabled?: boolean; icon?: Component; - iconSide?: string; + iconSide?: "left" | "right"; class?: string; loading?: boolean; holdToConfirm?: boolean; @@ -168,7 +182,15 @@ ...rest }: Props = $props(); - const classes = $derived(button({ variant, size, insetShadow, class: className })); + const classes = $derived( + button({ + variant, + size, + insetShadow, + iconSide: icon && children ? iconSide : "none", + class: className + }) + ); const spinnerClasses = $derived(buttonIcon({ size, class: spinnerClass })); const iconClasses = $derived(buttonIcon({ size })); const Icon = $derived(icon); diff --git a/web/src/lib/components/ui/ButtonCard.stories.svelte b/web/src/lib/components/ui/ButtonCard.stories.svelte index 43d9cf03e..bc318c1f4 100644 --- a/web/src/lib/components/ui/ButtonCard.stories.svelte +++ b/web/src/lib/components/ui/ButtonCard.stories.svelte @@ -35,7 +35,7 @@ -
+
diff --git a/web/src/lib/components/ui/ButtonCard.svelte b/web/src/lib/components/ui/ButtonCard.svelte index a04a421ee..21c0ab0b6 100644 --- a/web/src/lib/components/ui/ButtonCard.svelte +++ b/web/src/lib/components/ui/ButtonCard.svelte @@ -3,7 +3,7 @@ export const buttonCard = tv({ base: [ - "flex h-40 w-48 cursor-pointer gap-3 rounded-(--btn-radius) px-4 py-3 no-underline select-none [--btn-radius:var(--radius-sm)]", + "flex h-40 w-48 cursor-pointer gap-sm rounded-(--btn-radius) px-md py-sm no-underline select-none [--btn-radius:var(--radius-sm)]", "transition-colors duration-150 ease-in-out", "hover:no-underline", "focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-border-focus", @@ -89,9 +89,9 @@ {#snippet content()}
{#if title} -
+
{#if Icon} -