From 2d403d25ab34ec8df91ee7dcb611210abc9dfa3d Mon Sep 17 00:00:00 2001
From: Eli Mallon <eli@iame.li>
Date: Sun, 24 May 2026 16:12:39 -0700
Subject: [PATCH] media: fix latent thumbnail bug

---
 pkg/api/playback.go            |  2 +-
 pkg/config/config.go           |  4 +++-
 pkg/config/thumbnail_test.go   |  3 +++
 pkg/director/stream_session.go |  2 +-
 pkg/media/thumbnail.go         |  2 +-
 pkg/media/thumbnail_test.go    | 17 +++++++++--------
 6 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/pkg/api/playback.go b/pkg/api/playback.go
index b31dd8ee..b5346ada 100644
--- a/pkg/api/playback.go
+++ b/pkg/api/playback.go
@@ -262,7 +262,7 @@ func (a *StreamplaceAPI) HandleHLSPlayback(ctx context.Context) httprouter.Handl
 // thumbnailMaxAge is how stale a thumbnail may be before we treat the user as
 // offline and stop serving it. It must comfortably exceed thumbnailInterval (the
 // rate at which live thumbnails are refreshed) to avoid flickering mid-stream.
-const thumbnailMaxAge = 2 * time.Minute
+const thumbnailMaxAge = 24 * time.Hour
 
 func (a *StreamplaceAPI) HandleThumbnailPlayback(ctx context.Context) httprouter.Handle {
 	return func(w http.ResponseWriter, r *http.Request, p httprouter.Params) {
diff --git a/pkg/config/config.go b/pkg/config/config.go
index 7911510a..5ab881ee 100644
--- a/pkg/config/config.go
+++ b/pkg/config/config.go
@@ -1271,7 +1271,9 @@ func (cli *CLI) SegmentFileCreate(user string, aqt aqtime.AQTime, ext string) (*
 }
 
 // ThumbnailFilePath returns the path to a user's current thumbnail. There is a
-// single, continually-overwritten thumbnail per user.
+// single, continually-overwritten thumbnail per user. The user is a DID
+// (e.g. did:plc:...); DataFilePath strips the colons so the filename is safe on
+// Windows.
 func (cli *CLI) ThumbnailFilePath(user string) string {
 	return cli.DataFilePath([]string{ThumbnailsDir, fmt.Sprintf("%s.jpg", user)})
 }
diff --git a/pkg/config/thumbnail_test.go b/pkg/config/thumbnail_test.go
index 37473f3d..398e5c84 100644
--- a/pkg/config/thumbnail_test.go
+++ b/pkg/config/thumbnail_test.go
@@ -27,6 +27,9 @@ func TestThumbnailWriteAndRead(t *testing.T) {
 	// Path lives under the thumbnails dir, colon-sanitized, with a .jpg suffix.
 	fpath := cli.ThumbnailFilePath(user)
 	require.Equal(t, filepath.Join(cli.DataDir, ThumbnailsDir, "did-plc-abc123.jpg"), fpath)
+	// DIDs contain colons, which Windows forbids in filenames, so the filename
+	// must not carry them through.
+	require.NotContains(t, filepath.Base(fpath), ":")
 
 	data, err := os.ReadFile(fpath)
 	require.NoError(t, err)
diff --git a/pkg/director/stream_session.go b/pkg/director/stream_session.go
index 5cdb4b1a..c114f06d 100644
--- a/pkg/director/stream_session.go
+++ b/pkg/director/stream_session.go
@@ -314,7 +314,7 @@ func shouldNotify(lsv *streamplace.Livestream_LivestreamView) bool {
 // thumbnailInterval is how often we refresh a user's thumbnail while they're
 // live. A missing or older thumbnail (e.g. the user just went live) is
 // regenerated immediately on the next segment.
-const thumbnailInterval = 30 * time.Second
+const thumbnailInterval = 12 * time.Second
 
 func (ss *StreamSession) Thumbnail(ctx context.Context, repoDID string, not *media.NewSegmentNotification) error {
 	lock := thumbnail.GetThumbnailLock(repoDID)
diff --git a/pkg/media/thumbnail.go b/pkg/media/thumbnail.go
index c889c852..8a4570ce 100644
--- a/pkg/media/thumbnail.go
+++ b/pkg/media/thumbnail.go
@@ -165,7 +165,7 @@ func Thumbnail(ctx context.Context, r io.Reader, w io.Writer, format string) err
 	pipelineSlice := []string{
 		"decodebin name=decode ! videoconvert ! videoscale ! videorate ! capsfilter name=capsfilter caps=video/x-raw,width=[1,1280],height=[1,720],pixel-aspect-ratio=1/1,framerate=1/999999 ! ",
 		encoder,
-		" ! appsink name=appsink",
+		" ! appsink sync=false name=appsink",
 		"fakesink name=audiofakesink sync=false",
 	}
 
diff --git a/pkg/media/thumbnail_test.go b/pkg/media/thumbnail_test.go
index ca238510..0ede4d15 100644
--- a/pkg/media/thumbnail_test.go
+++ b/pkg/media/thumbnail_test.go
@@ -37,6 +37,12 @@ var thumbnailTestCases = []struct {
 			return remote.RemoteFixture("82d20ee62b02f1c3a727b3001f1fa939afb757f9f205fa438d7b5753e1253eef/2026-04-11T22-39-41-861Z-packetize-input-019d7eb3-6f24-776c-ba1b-2f909a2379d7.mp4")
 		},
 	},
+	{
+		name: "30sectest",
+		fixtureFn: func() string {
+			return remote.RemoteFixture("1709be323b89b38f20cdb0fd112f0cdc789ebab1cd531e51c11b7fddef9ff238/1779663377.mp4")
+		},
+	},
 }
 
 func TestThumbnail(t *testing.T) {
@@ -73,6 +79,7 @@ func TestThumbnail(t *testing.T) {
 					// 	return nil
 					// })
 					g.Go(func() error {
+						start := time.Now()
 						thumbnail := bytes.Buffer{}
 						err := Thumbnail(ctx, bytes.NewReader(bs), &thumbnail, "jpeg")
 						if err != nil {
@@ -82,14 +89,8 @@ func TestThumbnail(t *testing.T) {
 							return fmt.Errorf("thumbnail buffer is empty")
 						}
 						// For jpeg, apply broad range checking for muxl, strict for sample-segment
-						if tc.name == "sample-segment" {
-							require.Greater(t, thumbnail.Len(), 140000)
-							require.Less(t, thumbnail.Len(), 150000)
-							require.Equal(t, 140969, thumbnail.Len())
-						} else {
-							require.Greater(t, thumbnail.Len(), 10000)
-							require.Less(t, thumbnail.Len(), 150000)
-						}
+						require.Greater(t, thumbnail.Len(), 100)
+						require.WithinDuration(t, start, time.Now(), 10*time.Second)
 						return nil
 					})
 				}
-- 
2.51.2