From 96156a84ed614effb30b439c9e90f44b1f10aba8 Mon Sep 17 00:00:00 2001
From: Jer Miller <jeremie.miller@gmail.com>
Date: Sun, 26 Jul 2026 20:28:25 -0600
Subject: [PATCH] fix(import): show current source names in the import list

The import list now derives known source display names from SOURCE_METADATA at read time, so list rows use the current app copy instead of stale recorded labels.

Unknown source types and records without a source type keep their recorded display value, and the stored import record is left intact. Detail views can still show the recorded provenance from the saved import metadata.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 solstone/apps/import/routes.py            | 11 ++++
 solstone/apps/import/tests/test_routes.py | 72 +++++++++++++++++++++++
 tests/baselines/api/import/list.json      |  8 +--
 3 files changed, 87 insertions(+), 4 deletions(-)

diff --git a/solstone/apps/import/routes.py b/solstone/apps/import/routes.py
index dca9507cc..c959f5c6b 100644
--- a/solstone/apps/import/routes.py
+++ b/solstone/apps/import/routes.py
@@ -210,6 +210,14 @@ SOURCE_METADATA = [
 ]
 
 
+def _source_display_name(source_type: str | None) -> str | None:
+    """Return the current display name for a known source type, else None."""
+    if not source_type:
+        return None
+    entry = next((s for s in SOURCE_METADATA if s["name"] == source_type), None)
+    return entry["display_name"] if entry else None
+
+
 def _source_metadata_payload(source: dict[str, Any]) -> dict[str, Any]:
     payload = dict(source)
     payload["icon_svg"] = lucide_svg(source["icon"])
@@ -811,6 +819,9 @@ def import_list() -> Any:
             journal_root=Path(state.journal_root),
             timestamp=timestamp,
         )
+        display_name = _source_display_name(import_data.get("source_type"))
+        if display_name:
+            import_data["source_display"] = display_name
 
         # Calculate status based on processing state
         # Default status
diff --git a/solstone/apps/import/tests/test_routes.py b/solstone/apps/import/tests/test_routes.py
index dd716cbd3..ade4c5bd7 100644
--- a/solstone/apps/import/tests/test_routes.py
+++ b/solstone/apps/import/tests/test_routes.py
@@ -161,6 +161,15 @@ def client(tmp_path, monkeypatch):
     return app.test_client()
 
 
+def _seed_imported_json(journal: Path, timestamp: str, payload: dict) -> None:
+    import_dir = journal / "imports" / timestamp
+    import_dir.mkdir(parents=True, exist_ok=True)
+    (import_dir / "imported.json").write_text(
+        json.dumps(payload) + "\n",
+        encoding="utf-8",
+    )
+
+
 def test_import_index_serves_injected_spa_shell(client):
     response = client.get("/app/import/")
 
@@ -212,6 +221,69 @@ def test_import_sources_emit_icon_svg_not_emoji(client):
     assert "<svg" in by_name["quick"]["icon_svg"]
 
 
+def test_import_list_source_display_matches_current_metadata(client):
+    import importlib
+
+    import_routes = importlib.import_module("solstone.apps.import.routes")
+    journal = Path(import_routes.state.journal_root)
+    _seed_imported_json(
+        journal,
+        "20260101_100000",
+        {"source_type": "claude", "source_display": "Claude Chat"},
+    )
+    _seed_imported_json(
+        journal,
+        "20260101_110000",
+        {"source_type": "ics", "source_display": "Calendar"},
+    )
+    expected = {
+        source["name"]: source["display_name"]
+        for source in import_routes.SOURCE_METADATA
+    }
+
+    response = client.get("/app/import/api/list")
+
+    assert response.status_code == 200
+    for row in response.get_json()["imports"]:
+        source_type = row.get("source_type")
+        if source_type in expected:
+            assert row["source_display"] == expected[source_type]
+
+
+def test_import_list_preserves_display_for_unknown_source_types(client):
+    import importlib
+
+    import_routes = importlib.import_module("solstone.apps.import.routes")
+    journal = Path(import_routes.state.journal_root)
+    _seed_imported_json(
+        journal,
+        "20260101_100000",
+        {"source_type": "claude", "source_display": "Claude Chat"},
+    )
+    _seed_imported_json(
+        journal,
+        "20260101_110000",
+        {
+            "source_type": "not_a_real_source",
+            "source_display": "Some Recorded Name",
+        },
+    )
+    _seed_imported_json(
+        journal,
+        "20260101_120000",
+        {"source_display": "Recorded Only"},
+    )
+
+    response = client.get("/app/import/api/list")
+
+    assert response.status_code == 200
+    by_timestamp = {row["timestamp"]: row for row in response.get_json()["imports"]}
+    assert by_timestamp["20260101_100000"]["source_display"] == "Claude"
+    assert by_timestamp["20260101_110000"]["source_display"] == "Some Recorded Name"
+    assert by_timestamp["20260101_120000"]["source_type"] is None
+    assert by_timestamp["20260101_120000"]["source_display"] == "Recorded Only"
+
+
 def test_import_workspace_detail_static_wiring_and_deleted_tabs():
     workspace = (IMPORT_APP_ROOT / "workspace.html").read_text(encoding="utf-8")
 
diff --git a/tests/baselines/api/import/list.json b/tests/baselines/api/import/list.json
index c9cdde123..6d0666127 100644
--- a/tests/baselines/api/import/list.json
+++ b/tests/baselines/api/import/list.json
@@ -20,7 +20,7 @@
       "original_filename": "claude-conversations.json",
       "processed": true,
       "setting": "ai_conversation",
-      "source_display": "Claude Chat",
+      "source_display": "Claude",
       "source_type": "claude",
       "status": "success",
       "target_day": "20260101",
@@ -78,7 +78,7 @@
       "original_filename": "calendar-export.zip",
       "processed": true,
       "setting": "calendar",
-      "source_display": "Calendar",
+      "source_display": "calendar",
       "source_type": "ics",
       "status": "success",
       "target_day": "20260101",
@@ -136,7 +136,7 @@
       "original_filename": "My Clippings.txt",
       "processed": true,
       "setting": "kindle",
-      "source_display": "Kindle Highlights",
+      "source_display": "Kindle",
       "source_type": "kindle",
       "status": "success",
       "target_day": "20260101",
@@ -165,7 +165,7 @@
       "original_filename": "vault-export.zip",
       "processed": true,
       "setting": "obsidian",
-      "source_display": "Obsidian / Logseq Vault",
+      "source_display": "notes",
       "source_type": "obsidian",
       "status": "success",
       "target_day": "20260101",
-- 
2.51.2