From 978dfbde902802d21eaa40885d64ad90573316c3 Mon Sep 17 00:00:00 2001
From: Seongmin Lee <git@boltless.me>
Date: Sun, 25 Jan 2026 12:07:51 +0000
Subject: [PATCH] appview/oauth: remove `.Handle` from `oauth.AccountInfo`

We should resolve handle on render and we are already doing that.
Removing the unused field.

Signed-off-by: Seongmin Lee <git@boltless.me>
---
 appview/oauth/accounts.go | 3 ---
 appview/oauth/accounts_test.go | 21 +++++++++------------
 2 file(s) changed, 9 insertion(s)(+), 15 deletion(s)(-)

diff --git a/appview/oauth/accounts.go b/appview/oauth/accounts.go
--- a/appview/oauth/accounts.go
+++ b/appview/oauth/accounts.go
@@ -13,7 +13,6 @@
 
 type AccountInfo struct {
 	Did       string `json:"did"`
-	Handle    string `json:"handle"`
 	SessionId string `json:"session_id"`
 	AddedAt   int64  `json:"added_at"`
 }
@@ -74,7 +73,6 @@
 	for i, acc := range r.Accounts {
 		if acc.Did == did {
 			r.Accounts[i].SessionId = sessionId
-			r.Accounts[i].Handle = handle
 			return nil
 		}
 	}
@@ -85,7 +83,6 @@
 
 	r.Accounts = append(r.Accounts, AccountInfo{
 		Did:       did,
-		Handle:    handle,
 		SessionId: sessionId,
 		AddedAt:   time.Now().Unix(),
 	})
diff --git a/appview/oauth/accounts_test.go b/appview/oauth/accounts_test.go
--- a/appview/oauth/accounts_test.go
+++ b/appview/oauth/accounts_test.go
@@ -28,7 +28,7 @@
 		{
 			name: "add second account",
 			initial: []AccountInfo{
-				{Did: "did:plc:abc123", Handle: "alice.bsky.social", SessionId: "session-1", AddedAt: 1000},
+				{Did: "did:plc:abc123", SessionId: "session-1", AddedAt: 1000},
 			},
 			addDid:        "did:plc:def456",
 			addHandle:     "bob.bsky.social",
@@ -40,7 +40,7 @@
 		{
 			name: "update existing account session",
 			initial: []AccountInfo{
-				{Did: "did:plc:abc123", Handle: "alice.bsky.social", SessionId: "old-session", AddedAt: 1000},
+				{Did: "did:plc:abc123", SessionId: "old-session", AddedAt: 1000},
 			},
 			addDid:        "did:plc:abc123",
 			addHandle:     "alice.bsky.social",
@@ -112,8 +112,8 @@
 		{
 			name: "remove existing account",
 			initial: []AccountInfo{
-				{Did: "did:plc:abc123", Handle: "alice", SessionId: "s1"},
-				{Did: "did:plc:def456", Handle: "bob", SessionId: "s2"},
+				{Did: "did:plc:abc123", SessionId: "s1"},
+				{Did: "did:plc:def456", SessionId: "s2"},
 			},
 			removeDid: "did:plc:abc123",
 			wantLen:   1,
@@ -122,7 +122,7 @@
 		{
 			name: "remove non-existing account",
 			initial: []AccountInfo{
-				{Did: "did:plc:abc123", Handle: "alice", SessionId: "s1"},
+				{Did: "did:plc:abc123", SessionId: "s1"},
 			},
 			removeDid: "did:plc:notfound",
 			wantLen:   1,
@@ -131,7 +131,7 @@
 		{
 			name: "remove last account",
 			initial: []AccountInfo{
-				{Did: "did:plc:abc123", Handle: "alice", SessionId: "s1"},
+				{Did: "did:plc:abc123", SessionId: "s1"},
 			},
 			removeDid: "did:plc:abc123",
 			wantLen:   0,
@@ -171,9 +171,9 @@
 func TestAccountRegistry_FindAccount(t *testing.T) {
 	registry := &AccountRegistry{
 		Accounts: []AccountInfo{
-			{Did: "did:plc:first", Handle: "first", SessionId: "s1", AddedAt: 1000},
-			{Did: "did:plc:second", Handle: "second", SessionId: "s2", AddedAt: 2000},
-			{Did: "did:plc:third", Handle: "third", SessionId: "s3", AddedAt: 3000},
+			{Did: "did:plc:first", SessionId: "s1", AddedAt: 1000},
+			{Did: "did:plc:second", SessionId: "s2", AddedAt: 2000},
+			{Did: "did:plc:third", SessionId: "s3", AddedAt: 3000},
 		},
 	}
 
@@ -181,9 +181,6 @@
 		found := registry.FindAccount("did:plc:second")
 		if found == nil {
 			t.Fatal("FindAccount() returned nil for existing account")
-		}
-		if found.Handle != "second" {
-			t.Errorf("FindAccount() handle = %s, want second", found.Handle)
 		}
 		if found.SessionId != "s2" {
 			t.Errorf("FindAccount() sessionId = %s, want s2", found.SessionId)

--
tangled.sh