From af4d6fdfe06319ed98b74627ddd532be658c9a1e Mon Sep 17 00:00:00 2001
From: Lewis <lewis@tangled.org>
Date: Tue, 16 Jun 2026 09:47:13 +0300
Subject: [PATCH] appview/{pages,pulls}: redirect on pull create, dirty
 title+desc tracking

Lewis: May this revision serve well! <lewis@tangled.org>
---
 appview/pages/pages.go                                    | 2 ++
 .../templates/repo/pulls/fragments/pullComposeHost.html   | 5 +++++
 .../templates/repo/pulls/fragments/pullStepDetails.html   | 6 ++++++
 appview/pulls/compose.go                                  | 8 ++++++--
 appview/pulls/create.go                                   | 4 ++--
 5 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/appview/pages/pages.go b/appview/pages/pages.go
index 54f762c2..5c0353ab 100644
--- a/appview/pages/pages.go
+++ b/appview/pages/pages.go
@@ -1312,6 +1312,8 @@ type RepoNewPullParams struct {
 	Patch            string
 	Title            string
 	Body             string
+	TitleDirty       bool
+	BodyDirty        bool
 	IsStacked        bool
 	Comparison       *types.RepoFormatPatchResponse
 	Diff             *types.NiceDiff
diff --git a/appview/pages/templates/repo/pulls/fragments/pullComposeHost.html b/appview/pages/templates/repo/pulls/fragments/pullComposeHost.html
index a753eca0..96ee38c3 100644
--- a/appview/pages/templates/repo/pulls/fragments/pullComposeHost.html
+++ b/appview/pages/templates/repo/pulls/fragments/pullComposeHost.html
@@ -63,6 +63,11 @@
                         {{ template "repo/pulls/fragments/pullStepDetails" . }}
                     </div>
                 </section>
+            {{ else }}
+                <input type="hidden" name="title" value="{{ .Title }}" />
+                <input type="hidden" name="body" value="{{ .Body }}" />
+                <input type="hidden" name="titleDirty" value="{{ if .TitleDirty }}1{{ end }}" />
+                <input type="hidden" name="bodyDirty" value="{{ if .BodyDirty }}1{{ end }}" />
             {{ end }}
         </form>
 
diff --git a/appview/pages/templates/repo/pulls/fragments/pullStepDetails.html b/appview/pages/templates/repo/pulls/fragments/pullStepDetails.html
index 1cd26d99..955dfc54 100644
--- a/appview/pages/templates/repo/pulls/fragments/pullStepDetails.html
+++ b/appview/pages/templates/repo/pulls/fragments/pullStepDetails.html
@@ -23,6 +23,8 @@
 {{ define "pullStepDetailsSingle" }}
     {{ $root := .Root }}
     {{ $previewUrl := .PreviewUrl }}
+    <input type="hidden" name="titleDirty" id="titleDirty" value="{{ if $root.TitleDirty }}1{{ end }}" />
+    <input type="hidden" name="bodyDirty" id="bodyDirty" value="{{ if $root.BodyDirty }}1{{ end }}" />
     <div class="flex flex-col gap-1">
         <label for="title" class="text-xs tracking-wide text-gray-800 dark:text-gray-200">Title</label>
         <input
@@ -30,6 +32,7 @@
             name="title"
             id="title"
             value="{{ $root.Title }}"
+            oninput="document.getElementById('titleDirty').value='1'"
             class="w-full dark:bg-gray-800 dark:text-white dark:border-gray-700"
             placeholder="One-line summary of your change."
         />
@@ -42,6 +45,7 @@
         "Rows" 6
         "Placeholder" "Describe your change. Markdown is supported."
         "PreviewUrl" $previewUrl
+        "DirtyFlag" "bodyDirty"
     ) }}
 {{ end }}
 
@@ -52,6 +56,7 @@
     {{ $rows := .Rows }}
     {{ $placeholder := .Placeholder }}
     {{ $previewUrl := .PreviewUrl }}
+    {{ $dirtyFlag := .DirtyFlag }}
     <div class="flex flex-col gap-2" data-md-editor="{{ $id }}">
         <div class="btn-group self-start text-gray-600 dark:text-gray-300">
             <button type="button" data-md-mode="write"
@@ -79,6 +84,7 @@
                 rows="{{ $rows }}"
                 class="w-full resize-y dark:bg-gray-800 dark:text-white dark:border-gray-700"
                 placeholder="{{ $placeholder }}"
+                {{ if $dirtyFlag }}oninput="document.getElementById('{{ $dirtyFlag }}').value='1'"{{ end }}
             >{{ $value }}</textarea>
         </div>
         <div data-md-panel="preview" class="hidden">
diff --git a/appview/pulls/compose.go b/appview/pulls/compose.go
index 54b902d0..b32931ad 100644
--- a/appview/pulls/compose.go
+++ b/appview/pulls/compose.go
@@ -289,12 +289,14 @@ func (s *Pulls) composeParams(r *http.Request, repo *models.Repo) (pages.RepoNew
 
 	title := r.FormValue("title")
 	body := r.FormValue("body")
+	titleDirty := r.FormValue("titleDirty") == "1"
+	bodyDirty := r.FormValue("bodyDirty") == "1"
 	if comparison != nil && len(comparison.FormatPatch) > 0 {
 		first := comparison.FormatPatch[0]
-		if title == "" && first.PatchHeader != nil {
+		if !titleDirty && first.PatchHeader != nil {
 			title = first.Title
 		}
-		if body == "" && first.PatchHeader != nil {
+		if !bodyDirty && first.PatchHeader != nil {
 			body = first.Body
 		}
 	}
@@ -319,6 +321,8 @@ func (s *Pulls) composeParams(r *http.Request, repo *models.Repo) (pages.RepoNew
 		Patch:            patch,
 		Title:            title,
 		Body:             body,
+		TitleDirty:       titleDirty,
+		BodyDirty:        bodyDirty,
 		IsStacked:        isStacked,
 		Comparison:       comparison,
 		Diff:             diff,
diff --git a/appview/pulls/create.go b/appview/pulls/create.go
index 8c55d1b0..b2400369 100644
--- a/appview/pulls/create.go
+++ b/appview/pulls/create.go
@@ -335,7 +335,7 @@ func (s *Pulls) createPullRequest(
 	s.applyCreationLabels(r.Context(), client, userDid, []*models.Pull{pull}, r.Form, repo)
 
 	ownerSlashRepo := reporesolver.GetBaseRepoPath(r, repo)
-	http.Redirect(w, r, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pullId), http.StatusFound)
+	s.pages.HxRedirect(w, fmt.Sprintf("/%s/pulls/%d", ownerSlashRepo, pullId))
 }
 
 func (s *Pulls) createStackedPullRequest(
@@ -452,7 +452,7 @@ func (s *Pulls) createStackedPullRequest(
 	s.applyCreationLabels(r.Context(), client, userDid, stack, r.Form, repo)
 
 	ownerSlashRepo := reporesolver.GetBaseRepoPath(r, repo)
-	http.Redirect(w, r, fmt.Sprintf("/%s/pulls", ownerSlashRepo), http.StatusFound)
+	s.pages.HxRedirect(w, fmt.Sprintf("/%s/pulls", ownerSlashRepo))
 }
 
 func (s *Pulls) newStack(
-- 
2.51.2