From ec452e548a0d258060e6ada71403f3785b67eda1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 15 Nov 2018 04:15:43 -0800 Subject: [PATCH] Improve text overflow behavior for hovercards with (for example) long package names Summary: See PHI977. Ref T13216. Some text, like long package names, may overflow hovercards. Add overflow CSS behaviors to remedy this. Test Plan: Before: {F6012699} After: {F6012700} (You can use `/search/hovercard/` to render hovercards in a handy standalone way.) Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13216 Differential Revision: https://secure.phabricator.com/D19809 --- resources/celerity/map.php | 4 ++-- webroot/rsrc/css/phui/phui-hovercard.css | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index ee4a670dab..e147d89128 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -155,7 +155,7 @@ return array( 'rsrc/css/phui/phui-form.css' => '7aaa04e3', 'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f', 'rsrc/css/phui/phui-header-view.css' => '1ba8b707', - 'rsrc/css/phui/phui-hovercard.css' => 'f0592bcf', + 'rsrc/css/phui/phui-hovercard.css' => '4a484541', 'rsrc/css/phui/phui-icon-set-selector.css' => '87db8fee', 'rsrc/css/phui/phui-icon.css' => 'cf24ceec', 'rsrc/css/phui/phui-image-mask.css' => 'a8498f9c', @@ -821,7 +821,7 @@ return array( 'phui-head-thing-view-css' => 'fd311e5f', 'phui-header-view-css' => '1ba8b707', 'phui-hovercard' => '1bd28176', - 'phui-hovercard-view-css' => 'f0592bcf', + 'phui-hovercard-view-css' => '4a484541', 'phui-icon-set-selector-css' => '87db8fee', 'phui-icon-view-css' => 'cf24ceec', 'phui-image-mask-css' => 'a8498f9c', diff --git a/webroot/rsrc/css/phui/phui-hovercard.css b/webroot/rsrc/css/phui/phui-hovercard.css index 1f01362b6f..876b0b6e53 100644 --- a/webroot/rsrc/css/phui/phui-hovercard.css +++ b/webroot/rsrc/css/phui/phui-hovercard.css @@ -54,6 +54,8 @@ .phui-hovercard-body-item { margin: 4px 0 0 0; + overflow: hidden; + text-overflow: ellipsis; } .phui-hovercard-body-header { -- 2.51.2