From ddf26e89c8736b01376a48026f34be412a843b44 Mon Sep 17 00:00:00 2001
From: mainframe98 <k.s.werf@hotmail.com>
Date: Sun, 27 Oct 2024 18:47:04 +0000
Subject: [PATCH] DarkConsole: Fix "strlen(null)" but for the "tab" query parameter

Summary:
See rPf4d2811

Bug: T15344

Test Plan: Opened DarkConsole with /~/, saw no errors in DarkConsole

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25834
---
 src/applications/console/controller/DarkConsoleController.php | 2 +-
 1 file(s) changed, 1 insertion(s)(+), 1 deletion(s)(-)

diff --git a/src/applications/console/controller/DarkConsoleController.php b/src/applications/console/controller/DarkConsoleController.php
--- a/src/applications/console/controller/DarkConsoleController.php
+++ b/src/applications/console/controller/DarkConsoleController.php
@@ -35,7 +35,7 @@
     }
 
     $tab = $request->getStr('tab');
-    if (strlen($tab)) {
+    if (phutil_nonempty_string($tab)) {
       $this->writeDarkConsoleSetting(
         PhabricatorDarkConsoleTabSetting::SETTINGKEY,
         $tab);

--
tangled.sh