From d505dd2322afdb640e6b4285eee8fd4e7a443614 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Wed, 24 Sep 2025 12:24:46 +0200 Subject: [PATCH] Fix Dark Mode colors hovering navigation bar status tabs Summary: * Use `{$orange}` variable for warning text instead of hardcoding text color. * On hover, use `{$alphagrey}` variable for warning and fail text instead of hardcoding text color. This makes text readable in both dark mode and default mode. Refs T15056 Test Plan: * Go to http://phorge.localhost/settings/panel/display/ and set `Accessibility` to `Dark Mode (Experimental)` * Go to http://phorge.localhost/uiexample/view/PHUIListExample/, look at the "Status Tabs" section, hover over items * Repeat previous step with `Default Mode` instead of Dark Mode Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15056 Differential Revision: https://we.phorge.it/D26372 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/phui/phui-list.css | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 77037d9920..869fee368b 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'beb13d57', 'conpherence.pkg.js' => '020aebcf', - 'core.pkg.css' => '8958fe2d', + 'core.pkg.css' => '1bfee9a9', 'core.pkg.js' => '83580d78', 'dark-console.pkg.js' => '187792c2', 'differential.pkg.css' => '77189aae', @@ -160,7 +160,7 @@ return array( 'rsrc/css/phui/phui-invisible-character-view.css' => 'c694c4a4', 'rsrc/css/phui/phui-left-right.css' => '68513c34', 'rsrc/css/phui/phui-lightbox.css' => 'e4015eff', - 'rsrc/css/phui/phui-list.css' => '3cd9723f', + 'rsrc/css/phui/phui-list.css' => 'd9152fdb', 'rsrc/css/phui/phui-object-box.css' => 'b8d7eea0', 'rsrc/css/phui/phui-pager.css' => 'd022c7ad', 'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8', @@ -809,7 +809,7 @@ return array( 'phui-invisible-character-view-css' => 'c694c4a4', 'phui-left-right-css' => '68513c34', 'phui-lightbox-css' => 'e4015eff', - 'phui-list-view-css' => '3cd9723f', + 'phui-list-view-css' => 'd9152fdb', 'phui-object-box-css' => 'b8d7eea0', 'phui-oi-big-ui-css' => 'fa74cc35', 'phui-oi-color-css' => 'b517bfa0', diff --git a/webroot/rsrc/css/phui/phui-list.css b/webroot/rsrc/css/phui/phui-list.css index c3ffde0ee5..11b0c371ac 100644 --- a/webroot/rsrc/css/phui/phui-list.css +++ b/webroot/rsrc/css/phui/phui-list.css @@ -250,7 +250,7 @@ */ .phui-list-item-warn .phui-list-item-href { - color: #bc7837; + color: {$orange}; } .phui-list-item-fail .phui-list-item-href { @@ -260,13 +260,13 @@ .phui-list-item-warn.phui-list-item-selected .phui-list-item-href, .phui-list-item-warn .phui-list-item-href:hover { background: {$lightyellow}; - color: #bc7837; + color: rgba({$alphagrey},.9); } .phui-list-item-fail.phui-list-item-selected .phui-list-item-href, .phui-list-item-fail .phui-list-item-href:hover { background: {$lightred}; - color: {$red}; + color: rgba({$alphagrey},.9); } .phui-list-item-warn.phui-list-item-selected .phui-list-item-href:hover { -- 2.54.0