From cfd9fa7f559f993e31fcd6915b4857e0de877506 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 1 Oct 2018 11:06:00 -0700 Subject: [PATCH] Add an explicit "max-width" to PHUIDocumentPro pages to force large tables to scroll Summary: Ref T13202. See . If you put a very wide table in the markup for a new-layout Phriction page, it can push the actions element off screen to the right. Tables already get a scrollbar if encouraged strongly enough; add a `max-width` to encourage them. Test Plan: - Viewed pages with a large wrappable and non-wrappable content on mobile, tablet, and desktop. {F5915976} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13202 Differential Revision: https://secure.phabricator.com/D19723 --- resources/celerity/map.php | 4 ++-- webroot/rsrc/css/phui/phui-document-pro.css | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 720683c371..b6817f97eb 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -146,7 +146,7 @@ return array( 'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad', 'rsrc/css/phui/phui-crumbs-view.css' => '10728aaa', 'rsrc/css/phui/phui-curtain-view.css' => '2bdaf026', - 'rsrc/css/phui/phui-document-pro.css' => 'd033e8d5', + 'rsrc/css/phui/phui-document-pro.css' => 'dd79b5df', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf', 'rsrc/css/phui/phui-document.css' => 'c4ac41f9', 'rsrc/css/phui/phui-feed-story.css' => '44a9c8e9', @@ -814,7 +814,7 @@ return array( 'phui-curtain-view-css' => '2bdaf026', 'phui-document-summary-view-css' => '9ca48bdf', 'phui-document-view-css' => 'c4ac41f9', - 'phui-document-view-pro-css' => 'd033e8d5', + 'phui-document-view-pro-css' => 'dd79b5df', 'phui-feed-story-css' => '44a9c8e9', 'phui-font-icon-base-css' => '870a7360', 'phui-fontkit-css' => '1320ed01', diff --git a/webroot/rsrc/css/phui/phui-document-pro.css b/webroot/rsrc/css/phui/phui-document-pro.css index 520ae597cb..84dc11601f 100644 --- a/webroot/rsrc/css/phui/phui-document-pro.css +++ b/webroot/rsrc/css/phui/phui-document-pro.css @@ -34,6 +34,12 @@ layout: fixed; } +/* Force very wide content, like tables with many columns, to scroll inside + the frame. See T13202. */ +.phui-document-content-view { + max-width: 800px; +} + .device-desktop .phui-document-content-inner { display: table-row; } -- 2.51.2