From cb1e7ac75f51a2738e7c9c2e3707231e9e4045c1 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Tue, 13 Jan 2026 05:39:06 +0100
Subject: [PATCH] PHP 8.5: Avoid potential null array key in
 PhabricatorRepositoryPullLocalDaemon

Summary: Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

Test Plan:
Run static code analysis:
```
/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:269    Possibly invalid array key type int|string|null.
```

Reviewers: O1 Blessed Committers, valerio.bozzolan, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26678
---
 .../daemon/PhabricatorRepositoryPullLocalDaemon.php    | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
index 0dfe67cb1d..58eecbb9c3 100644
--- a/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
+++ b/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
@@ -266,10 +266,12 @@ final class PhabricatorRepositoryPullLocalDaemon
             }
           }
 
-          $retry_after[$repository_id] = $this->resolveUpdateFuture(
-            $pullable[$repository_id],
-            $future,
-            $min_sleep);
+          if ($repository_id !== null) {
+            $retry_after[$repository_id] = $this->resolveUpdateFuture(
+              $pullable[$repository_id],
+              $future,
+              $min_sleep);
+          }
 
           // We have a free slot now, so go try to fill it.
           break;
-- 
2.51.2