diff --git a/resources/celerity/map.php b/resources/celerity/map.php index a76bf0b824..67532fe686 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => 'beb13d57', 'conpherence.pkg.js' => '020aebcf', - 'core.pkg.css' => 'aaa7082d', + 'core.pkg.css' => '96104c33', 'core.pkg.js' => '9250c090', 'dark-console.pkg.js' => '187792c2', 'differential.pkg.css' => 'abdb4fe9', @@ -126,7 +126,7 @@ return array( 'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0', 'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc', 'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e', - 'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'fc69e136', + 'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'b0f5e99b', 'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '9b03a61f', 'rsrc/css/phui/phui-action-list.css' => 'b46ef6bd', 'rsrc/css/phui/phui-action-panel.css' => '88a4298b', @@ -815,7 +815,7 @@ return array( 'phui-oi-color-css' => 'b517bfa0', 'phui-oi-drag-ui-css' => 'da15d3dc', 'phui-oi-flush-ui-css' => '490e2e2e', - 'phui-oi-list-view-css' => 'fc69e136', + 'phui-oi-list-view-css' => 'b0f5e99b', 'phui-oi-simple-ui-css' => '9b03a61f', 'phui-pager-css' => 'd022c7ad', 'phui-pinboard-view-css' => '1f08f5d8', diff --git a/src/applications/auth/controller/config/PhabricatorAuthNewController.php b/src/applications/auth/controller/config/PhabricatorAuthNewController.php index cb1c537ca8..a14275c8ab 100644 --- a/src/applications/auth/controller/config/PhabricatorAuthNewController.php +++ b/src/applications/auth/controller/config/PhabricatorAuthNewController.php @@ -61,6 +61,7 @@ final class PhabricatorAuthNewController $item = id(new PHUIObjectItemView()) ->setHeader($provider->getNameForCreate()) ->setImageIcon($provider->newIconView()) + ->setHasSpriteImage(true) ->addAttribute($provider->getDescriptionForCreate()); if (!$already_exists) { diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php index b09e517bd4..dcc3a2d66b 100644 --- a/src/view/phui/PHUIObjectItemView.php +++ b/src/view/phui/PHUIObjectItemView.php @@ -21,6 +21,7 @@ final class PHUIObjectItemView extends AphrontTagView { private $imageURI; private $imageHref; private $imageIcon; + private $hasSpriteImage; private $titleText; private $badge; private $countdownNum; @@ -180,6 +181,21 @@ final class PHUIObjectItemView extends AphrontTagView { return $this->imageIcon; } + /** + * @param bool $sprite + */ + public function setHasSpriteImage($sprite) { + $this->hasSpriteImage = $sprite; + return $this; + } + + /** + * @return bool + */ + public function getHasSpriteImage() { + return $this->hasSpriteImage; + } + public function setCoverImage($image) { $this->coverImage = $image; return $this; @@ -673,10 +689,14 @@ final class PHUIObjectItemView extends AphrontTagView { ), ''); } else if ($this->getImageIcon()) { + $item_class = 'phui-oi-image-icon'; + if ($this->getHasSpriteImage()) { + $item_class = $item_class.' phui-oi-with-sprite-image'; + } $image = phutil_tag( 'div', array( - 'class' => 'phui-oi-image-icon', + 'class' => $item_class, ), $this->getImageIcon()); } diff --git a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css index 208fc80d81..4d0c298cc0 100644 --- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css +++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css @@ -635,6 +635,16 @@ ul.phui-oi-list-view .phui-oi-selected line-height: 36px; } +/* Set $hoverblue for auth icons to make them readable in dark mode */ +.phui-oi-image-icon.phui-oi-with-sprite-image { + background-image: radial-gradient(#eceff5 0%, #eceff5 60%, transparent 65%); + margin: 10px 2px 12px; +} + +.phui-icon-view.sprite-login { + margin-top: 6px; +} + .phui-oi-image { width: 40px; height: 40px;