From c5162074a12a0cd6ed53cc4c65bfbd6811941d63 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 28 Nov 2016 08:50:33 -0800 Subject: [PATCH] Fix an issue where internal Calendar DateTimes would not be correctly set to all-day Summary: Ref T11816. I don't really know what happened here, maybe I rewrote and broke this at the last second? In most cases, we directly respect the `isAllDay` flag on the event, so the internal date state doesn't matter too much. However, in the case of mail notifications, the raw internal state is relevant. This should fix mail notifications for all-day events. (I might still turn them off since I'm not sure they're too useful, but it's good to have them working.) Test Plan: - Created a new all-day event, verified database values wrote correctly. - Ran `bin/calendar notify --trace`, verified it picked up an all-day event tomorrow with a large enough `--minutes` value. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11816 Differential Revision: https://secure.phabricator.com/D16954 --- .../calendar/editor/PhabricatorCalendarEventEditor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php index b0cb844e9a..eee6b46751 100644 --- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php +++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php @@ -55,7 +55,7 @@ final class PhabricatorCalendarEventEditor if ($xaction->getTransactionType() != $type_allday) { continue; } - $target_alllday = (bool)$xaction->getNewValue(); + $new_allday = (bool)$xaction->getNewValue(); } $this->oldIsAllDay = $old_allday; -- 2.51.2