From c49d5104fd7a069b8e655fb07052b5d03a0e2e46 Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sat, 7 Feb 2026 13:34:13 +0100
Subject: [PATCH] a11y: Set label instead of name for textarea aria-label value

Summary:
Prefer a field label to a field name for the aria-label parameter value of a textarea element, as that is more descriptive.

Closes T16216

Test Plan:
1. Go to http://phorge.localhost/ponder/question/edit/form/default/
2. Inspect the <textarea> tag of `Answer Summary` which now says `aria-label="Answer Summary"` instead of `aria-label="answerWiki"`
3. Go to http://phorge.localhost/maniphest/task/edit/form/default/ while having a custom text field `Custom Field` defined
4. Inspect the <textarea> tag of `Description` which now says `aria-label="Description"` instead of `aria-label="description"`
5. Inspect the <textarea> tag of `Custom Field` which now says `aria-label="Custom Field"` instead of `aria-label="std:maniphest:custom.field"`

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16216

Differential Revision: https://we.phorge.it/D26730
---
 src/view/form/control/AphrontFormTextAreaControl.php | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/view/form/control/AphrontFormTextAreaControl.php b/src/view/form/control/AphrontFormTextAreaControl.php
index 8b75925f8d..6a4164f642 100644
--- a/src/view/form/control/AphrontFormTextAreaControl.php
+++ b/src/view/form/control/AphrontFormTextAreaControl.php
@@ -87,11 +87,18 @@ class AphrontFormTextAreaControl extends AphrontFormControl {
     // leading newlines if we don't do this. See T8707.
     $value = "\n".$value;
 
+    // Prefer the corresponding textarea "label" as "aria-label". If an element
+    // does not have one, fall back to element "name".
+    $aria_label = $this->getLabel();
+    if (!phutil_nonempty_string($aria_label)) {
+      $aria_label = $this->getName();
+    }
+
     return javelin_tag(
       'textarea',
       array(
         'name'        => $this->getName(),
-        'aria-label'  => $this->getName(),
+        'aria-label'  => $aria_label,
         'disabled'    => $this->getDisabled() ? 'disabled' : null,
         'readonly'    => $this->getReadOnly() ? 'readonly' : null,
         'class'       => $classes,
-- 
2.51.2