From bda8034982a23853be3e940e233b063ba2b6269d Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Mon, 24 Mar 2025 12:11:42 +0100 Subject: [PATCH] Make an IE CSS hack pass W3C CSS validator Summary: The W3C CSS validator throws `Value Error : margin-top Too many values or values are not recognized : 1px \9`. It does not complain about `1px\9`. See https://stackoverflow.com/questions/8004765/what-is-the-meaning-of-9-in-this-width-property-value-declaration, https://stackoverflow.com/questions/18907131/detecting-ie-version-using-css-capability-feature-detection, https://www.w3.org/TR/CSS2/syndata.html#characters Test Plan: Paste `core.pkg.css` into https://jigsaw.w3.org/css-validator/. Optionally, find some ancient Internet Explorer version and run it (I did not). Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25917 --- resources/celerity/map.php | 6 +++--- webroot/rsrc/css/phui/phui-form.css | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 03c13df0a8..0bbfe7cdb2 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => '3144a5e2', 'conpherence.pkg.js' => '020aebcf', - 'core.pkg.css' => '3406c4ea', + 'core.pkg.css' => '22e722fb', 'core.pkg.js' => '086da722', 'dark-console.pkg.js' => '187792c2', 'differential.pkg.css' => '91ac6214', @@ -154,7 +154,7 @@ return array( 'rsrc/css/phui/phui-feed-story.css' => 'a0c05029', 'rsrc/css/phui/phui-fontkit.css' => '1ec937e5', 'rsrc/css/phui/phui-form-view.css' => 'c35b66ed', - 'rsrc/css/phui/phui-form.css' => '8608beb3', + 'rsrc/css/phui/phui-form.css' => '8ea0227d', 'rsrc/css/phui/phui-formation-view.css' => 'd3956117', 'rsrc/css/phui/phui-head-thing.css' => 'd7f293df', 'rsrc/css/phui/phui-header-view.css' => '4cd25427', @@ -845,7 +845,7 @@ return array( 'phui-feed-story-css' => 'a0c05029', 'phui-font-icon-base-css' => 'e3b53e1e', 'phui-fontkit-css' => '1ec937e5', - 'phui-form-css' => '8608beb3', + 'phui-form-css' => '8ea0227d', 'phui-form-view-css' => 'c35b66ed', 'phui-formation-view-css' => 'd3956117', 'phui-head-thing-view-css' => 'd7f293df', diff --git a/webroot/rsrc/css/phui/phui-form.css b/webroot/rsrc/css/phui/phui-form.css index cc4c9aa8da..b33f8cddd0 100644 --- a/webroot/rsrc/css/phui/phui-form.css +++ b/webroot/rsrc/css/phui/phui-form.css @@ -85,7 +85,7 @@ div.jx-tokenizer-container-focused { input[type="radio"], input[type="checkbox"] { margin: 4px 0 0; - margin-top: 1px \9; + margin-top: 1px\9; /* IE8-9 */ line-height: normal; } -- 2.51.2