From bbc2ae78589ba2579c50cfe5c08d8b803cb39d0a Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 29 Jul 2016 07:02:36 -0700
Subject: [PATCH] Fix task graph fatal for graphs containing restricted tasks

Summary: Fixes T11392. If some tasks are restricted, we only have PHIDs for them, not objects. Just use the PHIDs instead.

Test Plan: {F1741335}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11392

Differential Revision: https://secure.phabricator.com/D16345
---
 src/infrastructure/graph/ManiphestTaskGraph.php | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/infrastructure/graph/ManiphestTaskGraph.php b/src/infrastructure/graph/ManiphestTaskGraph.php
index 53727b3779..2fe62af599 100644
--- a/src/infrastructure/graph/ManiphestTaskGraph.php
+++ b/src/infrastructure/graph/ManiphestTaskGraph.php
@@ -74,12 +74,10 @@ final class ManiphestTaskGraph
       $link = $viewer->renderHandle($phid);
     }
 
-
-
-    if ($this->isParentTask($object)) {
+    if ($this->isParentTask($phid)) {
       $marker = 'fa-chevron-circle-up bluegrey';
       $marker_tip = pht('Direct Parent');
-    } else if ($this->isChildTask($object)) {
+    } else if ($this->isChildTask($phid)) {
       $marker = 'fa-chevron-circle-down bluegrey';
       $marker_tip = pht('Direct Subtask');
     } else {
@@ -128,14 +126,14 @@ final class ManiphestTaskGraph
         ));
   }
 
-  private function isParentTask(ManiphestTask $task) {
+  private function isParentTask($task_phid) {
     $map = $this->getSeedMap(ManiphestTaskDependedOnByTaskEdgeType::EDGECONST);
-    return isset($map[$task->getPHID()]);
+    return isset($map[$task_phid]);
   }
 
-  private function isChildTask(ManiphestTask $task) {
+  private function isChildTask($task_phid) {
     $map = $this->getSeedMap(ManiphestTaskDependsOnTaskEdgeType::EDGECONST);
-    return isset($map[$task->getPHID()]);
+    return isset($map[$task_phid]);
   }
 
   private function getSeedMap($type) {
-- 
2.51.2