From ab3b70739614fe881d67c87003c4af3381b615da Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 28 Nov 2016 06:51:03 -0800 Subject: [PATCH] Fix local time test case for logged-out viewers using global settings Summary: In D16936, I changed logged-out viewers so they use global settings. This can lead to a `SELECT` from an isolated unit test. Instead, give the test fixtures and use standard `generateNewUser()` stuff. Test Plan: Ran `arc unit --everything`. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16952 --- src/view/__tests__/PhabricatorLocalTimeTestCase.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/view/__tests__/PhabricatorLocalTimeTestCase.php b/src/view/__tests__/PhabricatorLocalTimeTestCase.php index b007197834..a6ab67e8c5 100644 --- a/src/view/__tests__/PhabricatorLocalTimeTestCase.php +++ b/src/view/__tests__/PhabricatorLocalTimeTestCase.php @@ -2,11 +2,17 @@ final class PhabricatorLocalTimeTestCase extends PhabricatorTestCase { + protected function getPhabricatorTestCaseConfiguration() { + return array( + self::PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES => true, + ); + } + public function testLocalTimeFormatting() { - $user = new PhabricatorUser(); + $user = $this->generateNewTestUser(); $user->overrideTimezoneIdentifier('America/Los_Angeles'); - $utc = new PhabricatorUser(); + $utc = $this->generateNewTestUser(); $utc->overrideTimezoneIdentifier('UTC'); $this->assertEqual( -- 2.51.2