From a7ce15cf0819112f1253b735cc016553dac9224d Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Sun, 22 Feb 2026 21:25:04 +0100
Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception setting a Legalpad title

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php:22]
```

Same game as rPf7890322 in which I added the wrong exception to the commit message, sigh.

Closes T16505

Test Plan:
* Create a Legalpad at http://phorge.localhost/legalpad/edit/
* Go to http://phorge.localhost/feed/transactions/

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16505

Differential Revision: https://we.phorge.it/D26788
---
 .../legalpad/xaction/LegalpadDocumentTitleTransaction.php     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php b/src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php
index 725f4f4d4c..530bb7e101 100644
--- a/src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php
+++ b/src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php
@@ -19,7 +19,7 @@ final class LegalpadDocumentTitleTransaction
   public function getTitle() {
     $old = $this->getOldValue();
 
-    if (!strlen($old)) {
+    if (!phutil_nonempty_string($old)) {
       return pht(
         '%s created this document.',
         $this->renderAuthor());
@@ -35,7 +35,7 @@ final class LegalpadDocumentTitleTransaction
   public function getTitleForFeed() {
     $old = $this->getOldValue();
 
-    if (!strlen($old)) {
+    if (!phutil_nonempty_string($old)) {
       return pht(
         '%s created %s.',
         $this->renderAuthor(),
-- 
2.51.2