From a41b85788263e62d361a7e91c19767e807d4a8cd Mon Sep 17 00:00:00 2001 From: lkassianik Date: Tue, 17 Nov 2015 12:01:12 -0800 Subject: [PATCH] Ref T6049, Phurl object view should always display some sort of header. Summary: Ref T6049, Phurl object view should display Phurl name or Phurl long url as header. Test Plan: - Create Phurl with no name. Header should show long url as header. - Add name to Phurl. Header should be new Phurl name. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin Maniphest Tasks: T6049 Differential Revision: https://secure.phabricator.com/D14502 --- .../phurl/controller/PhabricatorPhurlURLViewController.php | 2 +- src/applications/phurl/storage/PhabricatorPhurlURL.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php index b0649cc62a..014d0eefef 100644 --- a/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php +++ b/src/applications/phurl/controller/PhabricatorPhurlURLViewController.php @@ -79,7 +79,7 @@ final class PhabricatorPhurlURLViewController $header = id(new PHUIHeaderView()) ->setUser($viewer) - ->setHeader($url->getName()) + ->setHeader($url->getDisplayName()) ->setStatus($icon, $color, $status) ->setPolicyObject($url); diff --git a/src/applications/phurl/storage/PhabricatorPhurlURL.php b/src/applications/phurl/storage/PhabricatorPhurlURL.php index cc90b6ce6a..34a143bc90 100644 --- a/src/applications/phurl/storage/PhabricatorPhurlURL.php +++ b/src/applications/phurl/storage/PhabricatorPhurlURL.php @@ -83,7 +83,7 @@ final class PhabricatorPhurlURL extends PhabricatorPhurlDAO if ($this->getName()) { return $this->getName(); } else { - return $this->getMonogram(); + return $this->getLongURL(); } } -- 2.51.2