From a2b0045dc9ed005111ed03deda98fb73cf99da3d Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sat, 29 Nov 2025 22:04:56 +0100 Subject: [PATCH] PHP 8.5: Mail: Do not add a null value to mail actor array Summary: Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead." ``` ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php:132] ``` Closes T16367 Test Plan: Go to a user profile page, select "Send Welcome Email", click "Send Email". Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T16367 Differential Revision: https://we.phorge.it/D26538 --- src/applications/metamta/storage/PhabricatorMetaMTAMail.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php index eee5cccdc9..d4510b39ab 100644 --- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php +++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php @@ -847,9 +847,12 @@ final class PhabricatorMetaMTAMail return $this->expandRecipients($actor_phids); } + /** + * @return array PHIDs and/or empty strings + */ private function getAllActorPHIDs() { return array_merge( - array($this->getParam('from')), + array($this->getParam('from', '')), $this->getToPHIDs(), $this->getCcPHIDs()); } -- 2.51.2