From 98c2ad38e5644543f09ad4621bfd2f1a70bfd3d6 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Wed, 30 Jul 2014 10:50:01 -0700 Subject: [PATCH] Fix audit commenting where there are only inlines Summary: been some changes here and this code was broked. turns out we re-assign $action like two lines later and never used the initial value, so we can simply delete the offending line. Fixes T5745. Test Plan: submitted inline comment pre-patch and fatal. re-submitted post patch and great success! Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5745 Differential Revision: https://secure.phabricator.com/D10078 --- src/applications/audit/editor/PhabricatorAuditCommentEditor.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/applications/audit/editor/PhabricatorAuditCommentEditor.php b/src/applications/audit/editor/PhabricatorAuditCommentEditor.php index 01b875f361..a26b9cc6f6 100644 --- a/src/applications/audit/editor/PhabricatorAuditCommentEditor.php +++ b/src/applications/audit/editor/PhabricatorAuditCommentEditor.php @@ -74,8 +74,6 @@ final class PhabricatorAuditCommentEditor extends PhabricatorEditor { 'commitPHID = %s', $commit->getPHID()); - $action = $comment->getAction(); - // TODO: We should validate the action, currently we allow anyone to, e.g., // close an audit if they muck with form parameters. I'll followup with this // and handle the no-effect cases (e.g., closing and already-closed audit). -- 2.54.0