diff --git a/src/applications/calendar/util/CalendarTimeUtil.php b/src/applications/calendar/util/CalendarTimeUtil.php index 0fc4f2e527..6051ade059 100644 --- a/src/applications/calendar/util/CalendarTimeUtil.php +++ b/src/applications/calendar/util/CalendarTimeUtil.php @@ -1,4 +1,5 @@ isChunkEngine()) { diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php index 330aecfca1..63ce763b69 100644 --- a/src/applications/home/controller/PhabricatorHomeMainController.php +++ b/src/applications/home/controller/PhabricatorHomeMainController.php @@ -219,7 +219,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController { $revisions = $revision_query->execute(); - list($blocking, $active,) = DifferentialRevisionQuery::splitResponsible( + list($blocking, $active) = DifferentialRevisionQuery::splitResponsible( $revisions, array($user_phid)); diff --git a/src/applications/oauthserver/PhabricatorOAuthResponse.php b/src/applications/oauthserver/PhabricatorOAuthResponse.php index 4e2c86c861..62c0fc9821 100644 --- a/src/applications/oauthserver/PhabricatorOAuthResponse.php +++ b/src/applications/oauthserver/PhabricatorOAuthResponse.php @@ -65,8 +65,7 @@ final class PhabricatorOAuthResponse extends AphrontResponse { } public function __construct() { - $this->setHTTPResponseCode(200); // assume the best - return $this; + $this->setHTTPResponseCode(200); // assume the best } public function getHeaders() { diff --git a/src/applications/oauthserver/PhabricatorOAuthServer.php b/src/applications/oauthserver/PhabricatorOAuthServer.php index e1b9f516ba..38b2e34623 100644 --- a/src/applications/oauthserver/PhabricatorOAuthServer.php +++ b/src/applications/oauthserver/PhabricatorOAuthServer.php @@ -64,8 +64,8 @@ final class PhabricatorOAuthServer extends Phobject { */ public function userHasAuthorizedClient(array $scope) { - $authorization = id(new PhabricatorOAuthClientAuthorization())-> - loadOneWhere( + $authorization = id(new PhabricatorOAuthClientAuthorization()) + ->loadOneWhere( 'userPHID = %s AND clientPHID = %s', $this->getUser()->getPHID(), $this->getClient()->getPHID()); diff --git a/src/applications/phame/controller/PhameController.php b/src/applications/phame/controller/PhameController.php index 3a455b195a..20acd8f098 100644 --- a/src/applications/phame/controller/PhameController.php +++ b/src/applications/phame/controller/PhameController.php @@ -1,5 +1,3 @@ getRenderingTarget() === - PhabricatorApplicationTransaction::TARGET_HTML) { + parent::TARGET_HTML) { $markup = hsprintf('%s', $name); } diff --git a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php index ac2957a4af..027e544776 100644 --- a/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php +++ b/src/infrastructure/lint/linter/PhabricatorJavelinLinter.php @@ -85,7 +85,7 @@ final class PhabricatorJavelinLinter extends ArcanistLinter { } public function getCacheGranularity() { - return ArcanistLinter::GRANULARITY_REPOSITORY; + return parent::GRANULARITY_REPOSITORY; } public function getCacheVersion() { diff --git a/src/view/widget/bars/AphrontGlyphBarView.php b/src/view/widget/bars/AphrontGlyphBarView.php index 5b8d606a27..b91a714b26 100644 --- a/src/view/widget/bars/AphrontGlyphBarView.php +++ b/src/view/widget/bars/AphrontGlyphBarView.php @@ -12,7 +12,7 @@ final class AphrontGlyphBarView extends AphrontBarView { private $bgGlyph; protected function getDefaultColor() { - return AphrontBarView::COLOR_AUTO_GOODNESS; + return parent::COLOR_AUTO_GOODNESS; } public function setValue($value) { diff --git a/src/view/widget/bars/AphrontProgressBarView.php b/src/view/widget/bars/AphrontProgressBarView.php index 7117435aa5..0a967a4fa5 100644 --- a/src/view/widget/bars/AphrontProgressBarView.php +++ b/src/view/widget/bars/AphrontProgressBarView.php @@ -9,7 +9,7 @@ final class AphrontProgressBarView extends AphrontBarView { private $alt = ''; protected function getDefaultColor() { - return AphrontBarView::COLOR_AUTO_BADNESS; + return parent::COLOR_AUTO_BADNESS; } public function setValue($value) {